hello,

On 2019-03-17 16:45, Klemens Nanni wrote:
On Sun, Mar 17, 2019 at 04:30:13PM -0400, Kurt Mosiejczuk wrote:
Is there a reason there is no python3 flavor? I checked and it supports
Python 2.7 and 3.4-3.7.

I was wondering the same and just started on moving this port to
Python 3 all together.

to answer the first part I ported this back when it was a dependency
for py-discogs-client, at some point it stopped being, and I've not
had real world tests for this since. So just didn't occur to me.
If this port has value, someone who uses (or depends on) it should
perhaps grab maintainership to ensure greater care and feeding.

Minimal dependencies are taken from setup.py.

@Johan: The release tarball (from PyPi) does not include tests/, but
they're present in the upstream git repo.  Would you mind tackling this
so downstreams like us can run tests with future releases?

I assume we use PyPi instead of github because github only provides the
auto generated tarballs and not proper ones?

Feedback? Objections?

Reads fine, as noted above I don't have any uses for this so no real
world tests.

.jh

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/py-coveralls/Makefile,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile
--- Makefile    17 Mar 2019 20:22:46 -0000      1.9
+++ Makefile    17 Mar 2019 20:41:04 -0000
@@ -3,6 +3,7 @@
 COMMENT =      display coverage stats online via coveralls.io

 MODPY_EGG_VERSION =    1.6.0
+REVISION =     0
 DISTNAME =     coveralls-${MODPY_EGG_VERSION}
 PKGNAME =      py-${DISTNAME}
 CATEGORIES =   devel
@@ -14,13 +15,13 @@ HOMEPAGE =  https://github.com/coagulant/
 PERMIT_PACKAGE_CDROM = Yes

 MODULES =              lang/python
-
+MODPY_VERSION =                ${MODPY_DEFAULT_VERSION_3}
 MODPY_PI =             Yes
 MODPY_SETUPTOOLS =     Yes

-RUN_DEPENDS =          devel/py-docopt \
-                       devel/py-coverage \
-                       www/py-requests
+RUN_DEPENDS =          devel/py-coverage${MODPY_FLAVOR}>=3.6 \
+                       devel/py-docopt${MODPY_FLAVOR}>=0.6.1 \
+                       www/py-requests${MODPY_FLAVOR}>=1.0.0

 NO_TEST =              Yes

Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/py-coveralls/pkg/PLIST,v
retrieving revision 1.5
diff -u -p -r1.5 PLIST
--- pkg/PLIST   17 Mar 2019 20:22:46 -0000      1.5
+++ pkg/PLIST   17 Mar 2019 20:41:04 -0000
@@ -9,18 +9,19 @@ lib/python${MODPY_VERSION}/site-packages

lib/python${MODPY_VERSION}/site-packages/coveralls-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt

lib/python${MODPY_VERSION}/site-packages/coveralls-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
 lib/python${MODPY_VERSION}/site-packages/coveralls/__init__.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/__init__.pyc
 lib/python${MODPY_VERSION}/site-packages/coveralls/__main__.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/__main__.pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}__main__.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}api.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}cli.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}exception.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}git.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}reporter.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/coveralls/${MODPY_PYCACHE}version.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/coveralls/api.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/api.pyc
 lib/python${MODPY_VERSION}/site-packages/coveralls/cli.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/cli.pyc
 lib/python${MODPY_VERSION}/site-packages/coveralls/exception.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/exception.pyc
 lib/python${MODPY_VERSION}/site-packages/coveralls/git.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/git.pyc
 lib/python${MODPY_VERSION}/site-packages/coveralls/reporter.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/reporter.pyc
 lib/python${MODPY_VERSION}/site-packages/coveralls/version.py
-lib/python${MODPY_VERSION}/site-packages/coveralls/version.pyc

Reply via email to