On 2019/03/17 19:37, Kurt Mosiejczuk wrote:
> On Sun, Mar 17, 2019 at 11:12:29PM +0000, Stuart Henderson wrote:
>
> > I like the direction this is taking, but it's missing use of a standard
> > MODULES mechanism, and a comment on style for commit -
>
> > There are several logically separate pieces here which would be
> > better to commit independently to keep the history clear.
>
> > I think MODPY_TEST_LOCALE also stands alone.
>
> Here's the second part adding MODPY_TEST_LOCALE.
>
> --Kurt
>
> Index: python.port.mk
> ===================================================================
> RCS file: /cvs/ports/lang/python/python.port.mk,v
> retrieving revision 1.100
> diff -u -p -r1.100 python.port.mk
> --- python.port.mk 4 Dec 2018 05:57:31 -0000 1.100
> +++ python.port.mk 17 Mar 2019 23:26:29 -0000
> @@ -159,6 +159,10 @@ MODPY_TEST_CMD = cd ${WRKSRC} && ${SETEN
> ${MODPY_BIN} ./${MODPY_SETUP} \
> ${MODPY_SETUP_ARGS}
>
> +MODPY_TEST_LOCALE ?= LC_CTYPE=en_US.UTF-8
> +
> +TEST_ENV += ${MODPY_TEST_LOCALE}
> +
> SUBST_VARS := MODPY_PYCACHE MODPY_COMMENT MODPY_ABI3SO
> MODPY_PYC_MAGIC_TAG \
> MODPY_BIN MODPY_EGG_VERSION MODPY_VERSION MODPY_BIN_SUFFIX \
> MODPY_PY_PREFIX MODPY_PYOEXTENSION ${SUBST_VARS}
>
This one's OK with me.
