On Thu, Mar 7, 2019 at 10:35 PM Anthony J. Bentley <anth...@anjbe.name> wrote:
> Stuart Henderson writes:
> > On 2019/03/07 13:55, Stefan Sperling wrote:
> > > On Thu, Mar 07, 2019 at 12:34:35AM -0700, Anthony J. Bentley wrote:
> > > > On Sun, Feb 17, 2019 at 2:57 PM Anthony J. Bentley <anth...@anjbe.name> 
> > > > w
> > rote:
> > > > >
> > > > > Alex Holst writes:
> > > > > > Hi,
> > > > > >
> > > > > > Thanks for your input. It should all be adopted into this port 
> > > > > > except
> > > > > > for the 'test' target which I couldn't get working otherwise.
> > > > >
> > > > > No need for a do-test, just use:
> > > > >
> > > > > CONFIGURE_ARGS =        -DBUILD_TESTING=ON
> > > >
> > > > Here's a port with that change, some minor whitespace changes, and a
> > > > tweaked DESCR.
> > > >
> > > > Is this ready to go in?
> > >
> > > Some files have the executable bit set, please clear them.
> > >
> > > It seems something is wrong with build dependencies.
> > > After 'make prepare' which installed cmake and ninja packages,
> > > I tried to run 'make package' and it failed:
> >
> > Setting -DBUILD_TESTING adds check as a build requirement.
> >
> > Is there a reason not to build the shared lib?
>
> Makes sense to me.
>
> Attached tarball builds shared lib, sets BUILD_DEPENDS properly,
> removes executable bit from files in the port directory.

Is this version ready for import? Any oks?

-- 
Anthony J. Bentley

Attachment: libsignal-protocol-c.tar.gz
Description: application/gzip

Reply via email to