Hello,
On 22/03/2019 10:27, Alessandro DE LAURENZIS wrote:
Hello Anthony,
thanks a lot for your feedback.
On 22/03/2019 06:16, Anthony J. Bentley wrote:
Hi Alessandro,
Alessandro DE LAURENZIS writes:
All tests are PASS, provided that we use gdiff(1) instead of diff(1) for
the dddmp set.
Careful...
-# Store corresponding CNF in different format:
+# Store corresponding CNF in gdifferent format:
# NodeByNode method -> file 4.node1.tmp
# MaxtermByMaxterm -> file 4.max1.tmp
-# Best with different options:
+# Best with gdifferent options:
Ooops. Fixed.
HOMEPAGE = https://sourceforge.net/projects/cudd-mirror/
I think https://www.davidkebo.com/cudd is a better homepage. I would use
both SourceForge and https://www.davidkebo.com/source/cudd_versions/ in
MASTER_SITES.
Actually David doesn't seem to be affiliated to the project in any way,
and his page is just a tutorial (there are a few on the net).
The most complete source I can find is a Github mirror:
https://github.com/ivmai/cudd
which contains a collection of the most recent releases and upstream's
README as front page.
I would suggest to switch to this as master site, but I'm facing issues
in fetching the tarball: we're trying to download:
https://github.com/ivmai/cudd/archive/3.0.0/cudd-3.0.0.tar.gz
instead of:
https://github.com/ivmai/cudd/archive/cudd-3.0.0.tar.gz
I vaguely remember a similar problem some months ago... do we have to
change something in ports' infrastructure?
One thing I'm not able to do is to force the name of the .so file to be
libcudd.so.0.0, instead of libcudd-3.0.0.so.0.0. Could someone point me
in the right direction?
Well, it seems to create both. I suppose you could @comment out the
redundant library in PLIST, but personally I wouldn't bother; in ports
like textproc/apertium I just leave it be. Which one does OpenSTA pick
up?
OpenSTA searches for libcudd-3.0.0.so.0.0 (so we would need
WANTLIB += cudd-3.0.0
which doesn't seem ideal to me, but maybe I'm wrong...).
I was wrong; OpenSTA picks libcudd.so.0.0 up (but still needs
WANTLIB+=cudd-3.0.0 for a clean port-lib-depends-check)
Also, I would prefer to add some documentation, given that it's
available in the release (although not updated to the latest version),
but I didn't find a way to do it using a target from the upstream's
Makefile; I just added a post-install part in the port's one (this
requires pdflatex, so I added print/texlive/base to BUILD_DEPENDS).
Updated tarball (using GH_ACCOUNT/PROJECT/TAGNAME, so breaking 'make
fetch') attached.
--
Alessandro DE LAURENZIS
[mailto:[email protected]]
Web: http://www.atlantide.t28.net
LinkedIn: https://www.linkedin.com/in/delaurenzis/