Hi!

On Sat, 23 Mar 2019 15:43:05 -0700
Andrew Hewus Fresh <[email protected]> wrote:

> 
> This updates p5-Text-Template to the current version, seems to be a
> huge modernization of the codebase to use current best practices.
> 
> https://metacpan.org/changes/distribution/Text-Template
> 
> Plus we have a new test dependency for it: devel/p5-Test-More-UTF8
> https://metacpan.org/pod/Test::More::UTF8
> use Test::More;
> use Test::More::UTF8;
> 
> # now we can easily use flagged strings without warnings like "Wide
> # character
> in print ..."
> is("\x{410}","\x{420}"); # got a failure message without warnings
> 
> 
> OK? Comments?

For Test::More::UTF8 i guess we should add: 

MAKE_ENV +=     TEST_POD=Yes

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/p5-Text-Template/Makefile,v
> retrieving revision 1.18
> diff -u -p -r1.18 Makefile
> --- Makefile  30 Apr 2017 15:47:03 -0000      1.18
> +++ Makefile  23 Mar 2019 22:38:44 -0000
> @@ -4,10 +4,15 @@ COMMENT=    expand template text with embed
>  
>  MODULES=     cpan
>  PKG_ARCH=    *
> -DISTNAME =   Text-Template-1.47
> +DISTNAME=    Text-Template-1.55
> [...]
> +FIX_EXTRACT_PERMISSIONS =    Yes

Also there is a spacing inconsistency for FIX_EXTRACT_PERMISSIONS.

In any case, OK cwen@ 

Charlène.

Reply via email to