On Sun, Mar 24 2019, Rafael Sadowski <raf...@sizeofvoid.org> wrote:
> On Sun Mar 24, 2019 at 01:25:36PM +0100, Rafael Sadowski wrote:
>> In the default KDE5 cmake configure all tests build in the main
>> build-task. What do you think about doing this only in a debug
>> environment?
I dislike having DEBUG semantics overloaded like this. When you track
down a bug, you don't want to hit new build failures just because you
compile the port using DEBUG=-g. This is why MODCMAKE_DEBUG was
introduced.
For a single port I would probably use a "test" PSEUDO_FLAVOR but I'm
not sure how easily this could be added to kf5.port.mk.
> This should speed up our bulk build!
Do you have a rough estimate of the speedup?
My two cents,
>> RS
>>
>
> Ops wrong diff. New diff below.
>
> Index: kf5.port.mk
> ===================================================================
> RCS file: /cvs/ports/devel/kf5/kf5.port.mk,v
> retrieving revision 1.10
> diff -u -p -u -p -r1.10 kf5.port.mk
> --- kf5.port.mk 22 Oct 2018 20:30:41 -0000 1.10
> +++ kf5.port.mk 24 Mar 2019 12:40:01 -0000
> @@ -17,6 +17,15 @@ CONFIGURE_STYLE = cmake
> .if ${CONFIGURE_STYLE:Mcmake}
> MODULES += devel/cmake
>
> +MODCMAKE_DEBUG ?= No
> +# Only build tests in a debug environment
> +. if ${MODCMAKE_DEBUG:L} == "yes" || defined(DEBUG)
> +CONFIGURE_ARGS += -DBUILD_TESTING=ON
> +NO_TEST= Yes
> +. else
> +CONFIGURE_ARGS += -DBUILD_TESTING=OFF
> +. endif
> +
> # set up default locations
> CONFIGURE_ARGS += \
> -DECM_MKSPECS_INSTALL_DIR=${PREFIX}/share/kf5/mkspecs \
>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
