On Thu, Mar 21 2019, Charlene Wendling <[email protected]> wrote: > Hi ports, > > This update causes various issues on powerpc (ports-clang is used > for this one): > > 1) "There's nowhere that max_align_t is defined" > > bcallah@ found this during an attempt to build webkigtk4 on macppc > with gcc-8.2 as ports-gcc [0]. I still use gcc-4.9 on my side, > same thing. I'll let him address this issue as he's working on it. > > Temporarily i made a quick fix in webkitgtk4's code itself.
This has been fixed in g++-4.9.4p18. > 2) Unsigned char by default > > There are a few occurences of narrowing to signed char that > breaks the build on macppc. > > I fixed them as clang++ told me where they were. > > 3) __mulodi4 generated by ports-clang on powerpc > > This is a follow-up of my diff against v2.22. Code changed, and so > is the patch. > > Testing: > > - nothing is broken on amd64 (the build log is here, > ยก28 Mbytes! [1]), i used surf without issues. > - on macppc, it indeed builds, the runtime is still meh. > According to various tests i did, the network code may be to > blame [2]. > I can display a prefetched OpenBSD homepage, even run basic > javascript. As soon as i really want to browse online, i've the > classical "Internal webkit error". > > > Given that no webkitgtk4 means no Gnome, i felt like sharing early, > as iirc arm* will be hit by 2). Looks likely indeed. > Opinions, comments, testing [...] welcome :) The unsigned char fixes and the relocation overflow flags look fine. For 3) I'm wondering which other architectures might be affected, at least sparc64 isn't. Maybe 32 bits architectures only, like hppa? We may have to refine the #ifdef test later. ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
