On 2019/03/25 10:41, Renaud Allard wrote:
> Hello,
> 
> This patch adds spf commands to exim.
> 
> Best Regards
> 

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/mail/exim/Makefile,v
> retrieving revision 1.121
> diff -u -p -r1.121 Makefile
> --- Makefile  12 Feb 2019 11:48:33 -0000      1.121
> +++ Makefile  25 Mar 2019 09:30:38 -0000
> @@ -27,7 +27,8 @@ MASTER_SITES =              https://ftp.exim.org/pub
>                       ftp://ftp.exim.org/pub/exim/exim4/ \
>                       http://mirror.switch.ch/ftp/mirror/exim/exim/exim4/
>  
> -LIB_DEPENDS-main =   converters/libiconv devel/pcre
> +LIB_DEPENDS-main =   converters/libiconv devel/pcre mail/libspf2

like opendmarc: one dep per line, and you have libspf2 without an
accompanying WANTLIB. if you didn't get a 'NOT NEEDED' error then it's
because of ...

> +RUN_DEPENDS-main =   mail/libspf2

... you shouldn't have the same thing in RUN_DEPENDS and LIB_DEPENDS

> +@@ -985,9 +985,9 @@ ZCAT_COMMAND=/usr/bin/zcat
> + # installed on your system (www.libspf2.org). Depending on where it is 
> installed
> + # you may have to edit the CFLAGS and LDFLAGS lines.
> + 
> +-# SUPPORT_SPF=yes
> +-# CFLAGS  += -I/usr/local/include
> +-# LDFLAGS += -lspf2
> ++SUPPORT_SPF=yes
> ++CFLAGS  += -I/usr/local/include
> ++LDFLAGS += -lspf2

Try it without CFLAGS here. If it fails then pass it in via the ports Makefile
somehow (as -I${LOCALBASE}/include, don't hardcode /usr/local).

> + # ENABLE_DISABLE_FSYNC=yes
> + 
> + # End of EDITME for Exim 4.
> ++EXIM_MONITOR=eximon.bin
> ++ BIN_DIRECTORY=/usr/local/bin
> ++ CONFIGURE_FILE=/etc/exim/configure
> ++ LOOKUP_INCLUDE=
> ++ LOOKUP_LIBS=
> ++ EXTRALIBS_EXIM=-L/usr/local/lib -liconv
> ++ CFLAGS=-O2 -pipe   
> ++ INCLUDE=-I/usr/local/include
> ++EXIM_MONITOR=eximon.bin
> ++ BIN_DIRECTORY=/usr/local/bin
> ++ CONFIGURE_FILE=/etc/exim/configure
> ++ LOOKUP_INCLUDE=
> ++ LOOKUP_LIBS=
> ++ EXTRALIBS_EXIM=-L/usr/local/lib -liconv
> ++ CFLAGS=-O2 -pipe   
> ++ INCLUDE=-I/usr/local/include
> ++EXIM_MONITOR=eximon.bin
> ++ BIN_DIRECTORY=/usr/local/bin
> ++ CONFIGURE_FILE=/etc/exim/configure
> ++ LOOKUP_INCLUDE=
> ++ LOOKUP_LIBS=
> ++ EXTRALIBS_EXIM=-L/usr/local/lib -liconv
> ++ CFLAGS=-O2 -pipe   
> ++ INCLUDE=-I/usr/local/include

This chunk shouldn't be in the patch.

Also needs a REVISION bump.

Reply via email to