On 2019/03/30 19:17, Kurt Mosiejczuk wrote:
> On Sun, Mar 31, 2019 at 12:06:56AM +0100, Klemens Nanni wrote:
> > On Tue, Mar 26, 2019 at 11:34:49PM -0400, Kurt Mosiejczuk wrote:
> > > Someone asked me to look at porting tootstream. It needs the two new ports
> > > I sent yesterday, py-humanize and py-emoji but otherwise uses things
> > > Pamela already ported like py-mastodon.py. I honestly expected to have
> > > to fight it more. It worked just fine for me on bsd.network.
> > HOMEPAGE has TLS, space after MODPY_PYTEST's "=", otherwise OK kn.
> 
> > I'd also add the following version specs to *DEPS as per 
> > src/tootstream.egg-info/requires.txt, but that's up to you:
> 
> >     click>=6.7
> >     Mastodon.py==1.3.1
> >     colored>=1.3.5
> >     humanize>=0.5.1
> >     emoji>=0.4.5
> 
> I guess when our version was already greater than the requirements I
> had been leaving version specifiers off. I figured I haven't seen us
> going to earlier versions of python ports. 

That is the approach I would go for too. Few people will bother to update
them when updating the port. However the hard dependency on the specific
Mastodon.py version should be listed.

> Is it considered a good practice to put those in even in those cases?
> 
> --Kurt
> 

Reply via email to