On Mon, Apr 08 2019, Christian Weisgerber <[email protected]> wrote:
> Stuart Henderson:
>
>> > https://www.samba.org/samba/history/samba-4.8.11.html
>>
>> I think we want this for release if possible.
>
> I agree.
>
>> have you had chance to test on !clang?
>
> This must be confirmed.
Sorry for not making that clear: my sparc64 builder is running a bulk
with this samba update, poppler-0.75 and gcc-8, but samba hasn't been
hit yet. So I haven't been able to test on a base-gcc arch yet
(base-gcc is the compiler used there).
I did however test a build on amd64 using base-gcc, it requires a change
in the jansson headers. I think this test is sufficient, but YMMV.
ok?
--- /usr/local/include/jansson_config.h.orig Tue Apr 9 17:05:37 2019
+++ /usr/local/include/jansson_config.h Tue Apr 9 16:43:41 2019
@@ -61,7 +61,7 @@
/* If __atomic builtins are available they will be used to manage
reference counts of json_t. */
-#define JSON_HAVE_ATOMIC_BUILTINS 1
+//#define JSON_HAVE_ATOMIC_BUILTINS 1
/* If __atomic builtins are not available we try using __sync builtins
to manage reference counts of json_t. */
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
