On Fri, Apr 12, 2019 at 10:25:25AM +0200, Jeremie Courreges-Anglas wrote: > > On Wed, Apr 10 2019, Kevin Lo <[email protected]> wrote: > > On Wed, Apr 10, 2019 at 03:48:04PM +0800, Kevin Lo wrote: > >> > >> Hi, > >> > >> When I run the command m17n-dump, I get an error: > >> undefined reference to `libintl_bindtextdomain' > >> > >> The diff below links with intl correctly, ok? > > > > Here's the revised diff that fixes m17n-view as well. > > There are indeed two problems, one with ld and libintl, another one with > the detection of Xaw. Here's an alternate diff which, compared > to yours: > - adds -lintl only to the build of libm17n-core, since this is the > library using bindtextdomain. I'd prefer this approach since it > doesn't result in overlinking and it can be pushed upstream as is. > - also removes -ldl from the build of libm17n > - adds both /usr/X11R6 and /usr/local to CPPFLAGS/LDFLAGS, for > consistency. No need to respect user CPPFLAGS, only LDFLAGS. > - removes patch-configure, it's normal for libtool+autoconf to detect > whether libdl.so is available/needed > > Tested on amd64 with both clang/ld.lld and gcc/ld.bfd. > Does it work for you?
I tested m17n-conv, m17n-date, m17n-dump, m17n-edit and m17n-view, all worked nicely :) Thanks.
