On 2019/04/21 13:04, Rafael Sadowski wrote:
> On Sun Apr 21, 2019 at 11:40:24AM +0100, Stuart Henderson wrote:
> > On 2019/04/21 12:32, Rafael Sadowski wrote:
> > > Update pycharm to the latest stable 2019 release. It works quite well
> > > with JDK11. Are there any reasons not to switch to JDK11?
> >
> > Setting MODJAVA_VER=1.8+ already allows it to work with either 1.8 or 11.
> > So the question should be, "is there any reason to prohibit people using
> > it with 1.8".
> >
> Hi Stuart,
>
> Thanks for your feedback. 1.8+, that wasn't clear to me. There is no
> reason to prohibit the use of 1.8.
I wonder if we can improve that. Did you find the explanation for
MODJAVA_VER unclear, or did you not find it in port-modules(5)?
> > Also files/pycharm is broken, it should use javaPathHelper.
> >
> I don't understand. "files/pycharm"?
/usr/ports/devel/pycharm/files/pycharm sets the path to java at port
build time based on the *build* dependency version -
export PYCHARM_JDK=${JAVA_HOME}
and JAVA_HOME is substituted via SUBST_CMD / SUBST_VARS.
So currently the file always has 1.8. But because the run dependency
is flexible, the user might not have 1.8 installed.
It should have a RUN_DEPENDS on java/javaPathHelper, and instead of the
subst'ed JAVA_HOME, it should use $(javaPathHelper -h pycharm) - the
same problem exists in devel/intellij.
