> On 2019/04/23 18:16, Kurt Mosiejczuk wrote: > On Tue, Apr 23, 2019 at 01:52:24PM +0100, Stuart Henderson wrote: >> Unbreaks with python 3.7. No problems seen with dep's. OK? > > Needs a NO_TEST. Tests aren't bundled in with the new tarball. > > Otherwise it builds fine on arm64, sparc64, and amd64 here. > > With NO_TEST, OK kmos@
Hi! Please forgive me for this drive-by post, but I'm the maintainer of gevent and happened to see this message go by and it made me curious. Can you please help me understand what you mean by "Tests aren't bundled in with the new tarball?" I thought I was including them. It is true that `greentest/testrunner.py` is no more. That was replaced with `python -m gevent.tests`: $ python3.7 -m venv ./gevent $ cd ./gevent $ wget https://files.pythonhosted.org/packages/ed/27/6c49b70808f569b66ec7fac2e78f076e9b204db9cf5768740cff3d5a07ae/gevent-1.4.0.tar.gz $ tar -xf ./gevent-1.4.0.tar.gz $ . bin/activate (gevent) $ cd gevent-1.4.0/ (gevent) $ python setup.py build_ext -i ... (gevent) $ PYTHONPATH=src python -m gevent.tests Running tests in parallel with concurrency 7 + //python -u -mgevent.tests.test__GreenletExit + //python -u -mgevent.tests.test___config ... + GEVENT_DEBUG=error /private/tmp/gevent/bin/python -u -W ignore -m gevent.testing.monkey_test test_ssl.py - GEVENT_DEBUG=error /private/tmp/gevent/bin/python -u -W ignore -m gevent.testing.monkey_test test_asyncore.py [Ran 101 tests in 5.6s (skipped=50)] + GEVENT_DEBUG=error /private/tmp/gevent/bin/python -u -W ignore -m gevent.testing.monkey_test test_subprocess.py - GEVENT_DEBUG=error /private/tmp/gevent/bin/python -u -W ignore -m gevent.testing.monkey_test test_ftplib.py [Ran 88 tests in 6.9s] ... Of course, the test dependencies listed in setup.py must be available to run all the tests (I think only objgraph is a hard dependency, if the others are missing there will be degraded performance or spurious failures). Compared to 1.2, if the CFFI backends aren't built, there will be some extra test failures; likewise if dnspython isn't installed. If gevent itself isn't installed some tests will also fail when they spawn subprocesses that don't inherit PYTHONPATH (probably 1.2 was the same? I don't remember). Many of those are things I'm working to clean up for gevent 1.5 (e.g., it no longer requires the CFFI backends [https://github.com/gevent/gevent/issues/1366]). Let me know if I can help in any way. Thanks, Jason (I'm not subscribed so I would appreciate being CCd on replies.)
