On Sun, 28 Apr 2019 17:35:48 +0200
Antoine Jacoutot <[email protected]> wrote:

> On Sun, Apr 28, 2019 at 03:15:33PM +0200, Charlene Wendling wrote:
> > 
> > Ping, with an updated diff. 
> 
> We're in the middle of a major GNOME update. Could this wait until
> g2k19? Maybe some of these won't be needed anymore.

Sure! I think a global solution would be preferable anyway. Also
they were not buildable with ports-gcc-4.9, so there is no bad
surprise ;)

> > 
> > On Sun, 14 Apr 2019 12:18:31 +0200
> > Charlene Wendling <[email protected]> wrote:
> > 
> > > Hi ports, 
> > > 
> > > (obviously for post unlock)
> > > 
> > > After having built meta/{xfce,lxqt,mate} flawlessly on my
> > > powerbook, it was time to see how far meta/gnome would go with
> > > ports-gcc-8.
> > > 
> > > It requires only COMPILER fixes. In a future GNOME update, maybe
> > > we should set a global COMPILER in gnome.port.mk, like
> > > qt5.port.mk has. Currently it uses base compilers by default.
> > > 
> > > Here is a pretty raw report taken from my notes. 
> > > 
> > > Fixed ports (there is a diff at the end for them): 
> > > 
> > > > x11/gnome/mutter
> > >     "cc1: error: -Werror=maybe-uninitialized: No option
> > >     -Wmaybe-uninitialized" 
> > >     The option is too recent for base-gcc, changed COMPILER. May
> > > also work with ports-gcc-4.9 (it's supported there).
> > > 
> > > > x11/gnome/usage
> > > > x11/gnome/bijiben
> > >     "error: 'for' loop initial declaration used outside C99 mode"
> > >     Requires modern C support or fixing the code. Changed
> > > COMPILER. ports-gcc-4.9 would need -std=c99.
> > >     I don't know what we should do with ports-gcc-4.9 possible
> > >     fixes post-unlock, that diff clearly targets ports-gcc-8. 
> > > 
> > > 
> > > Broken ports (only "new" breakages):
> > > 
> > > > x11/gnome/builder
> > >     "ERROR: Problem encountered: libgit2 was not compiled with"
> > >     "-DTHREADSAFE:BOOL=ON"
> > >     There may be a reason it wasn't compiled with it. I haven't
> > >     looked at the issue yet, but any info is welcome.
> > > 
> > > > x11/gnome/shell
> > > > x11/gnome/shell-extensions
> > >     "Unable to allocate memory: std::bad_alloc"
> > >     Probably hit by arch limits, changed COMPILER without success
> > > 
> > > 
> > > 
> > > Comments are welcome :) 
> > > 
> > > Charlène. 
> > > 
> > 
> > 
> > Index: bijiben/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/x11/gnome/bijiben/Makefile,v
> > retrieving revision 1.57
> > diff -u -p -u -p -r1.57 Makefile
> > --- bijiben/Makefile        21 Feb 2019 17:08:50 -0000      1.57
> > +++ bijiben/Makefile        28 Apr 2019 13:13:30 -0000
> > @@ -4,7 +4,7 @@ COMMENT=            simple note editor
> >  
> >  GNOME_PROJECT=             bijiben
> >  GNOME_VERSION=             3.30.3
> > -REVISION=          0
> > +REVISION=          1
> >  
> >  # GPLv3
> >  PERMIT_PACKAGE_CDROM=      Yes
> > @@ -14,6 +14,8 @@ WANTLIB += gdk-3 gdk_pixbuf-2.0 gio-2.0 
> >  WANTLIB += gobject-2.0 gtk-3 ical intl javascriptcoregtk-4.0 m
> >  WANTLIB += pango-1.0 pangocairo-1.0 pthread secret-1 soup-2.4
> >  WANTLIB += tracker-sparql-2.0 uuid webkit2gtk-4.0 xml2
> > +
> > +COMPILER=          base-clang ports-gcc
> >  
> >  MODULES=           devel/dconf \
> >                     devel/meson \
> > Index: mutter/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/x11/gnome/mutter/Makefile,v
> > retrieving revision 1.90
> > diff -u -p -u -p -r1.90 Makefile
> > --- mutter/Makefile 20 Jan 2019 04:55:56 -0000      1.90
> > +++ mutter/Makefile 28 Apr 2019 13:13:32 -0000
> > @@ -4,7 +4,7 @@ COMMENT=            window and compositing
> > manager 
> >  GNOME_PROJECT=             mutter
> >  GNOME_VERSION=             3.30.2
> > -REVISION=          1
> > +REVISION=          2
> >  
> >  API_SUFFIX=                -3
> >  SUBST_VARS=                API_SUFFIX
> > @@ -27,6 +27,8 @@ WANTLIB += vorbisfile xcb xcb-dri2 xcb-d
> >  WANTLIB += xcb-randr xcb-render xcb-res xcb-shm xcb-sync xcb-util
> >  WANTLIB += xcb-xfixes xcb-xkb xkbcommon xkbcommon-x11 xkbfile
> >  WANTLIB += xshmfence z
> > +
> > +COMPILER=          base-clang ports-gcc
> >  
> >  MODULES=           devel/dconf \
> >                     x11/gnome
> > Index: usage/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/x11/gnome/usage/Makefile,v
> > retrieving revision 1.6
> > diff -u -p -u -p -r1.6 Makefile
> > --- usage/Makefile  28 Apr 2019 09:22:14 -0000      1.6
> > +++ usage/Makefile  28 Apr 2019 13:13:32 -0000
> > @@ -4,6 +4,7 @@ COMMENT=            system resources status
> >  
> >  GNOME_PROJECT=             gnome-usage
> >  GNOME_VERSION=             3.32.0
> > +REVISION=          0
> >  
> >  CATEGORIES=                sysutils
> >  
> > @@ -13,6 +14,8 @@ PERMIT_PACKAGE_CDROM=     Yes
> >  WANTLIB += atk-1.0 c cairo cairo-gobject dazzle-1.0 gdk-3
> > gdk_pixbuf-2.0 WANTLIB += gio-2.0 glib-2.0 gobject-2.0 gtk-3
> > gtop-2.0 intl m WANTLIB += pango-1.0 pangocairo-1.0
> > +
> > +COMPILER=          base-clang ports-gcc
> >  
> >  MODULES=           devel/dconf \
> >                     devel/meson \
> > 
> 
> -- 
> Antoine
> 

Reply via email to