On Sun, Apr 28, 2019 at 12:30:28PM -0400, Kurt Mosiejczuk wrote:
> On Sat, Apr 27, 2019 at 12:30:52PM +0200, Martin Reindl wrote:
>
> > > Hello ports,
>
> > > Attached is a new port of net/py-siphon:
>
> > > Siphon is a collection of Python utilities for downloading data from
> > > remote data services. Much of Siphon's current functionality focuses
> > > on access to data hosted on a THREDDS Data Server. It also provides
> > > clients to a variety of simple web services.
>
> > Resending. Anyone wants to take a look at this?
>
> The ports tree has a wee bit of chaos going on at the moment, so this
> will be an incomplete review, but I figure I'll give you the feedback
> I have so far.
>
> 1) *_DEPENDS should be sorted alphabetically.
>
> 2) The setup.py indicates needing py-enum34 for versions < 3.4. So you should
> include that for the python 2 flavor.
>
> 3) Is there an advantage to pulling from github rather than PyPi?
Kurt,
Thank you for the valuable feedback, I adapted the port accordingly. And
pulling from pypi is indeed simpler.
-m
Index: Makefile
===================================================================
RCS file: Makefile
diff -N Makefile
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ Makefile 28 Apr 2019 18:52:37 -0000
@@ -0,0 +1,43 @@
+# $OpenBSD$
+
+COMMENT= download data from remote data services (such as THREDDS)
+
+MODPY_EGG_VERSION= 0.8.0
+DISTNAME= siphon-${MODPY_EGG_VERSION}
+PKGNAME= py-${DISTNAME}
+CATEGORIES= net
+
+HOMEPAGE= http://unidata.github.io/cftime/
+
+MAINTAINER= Martin Reindl <[email protected]>
+
+# BSD
+PERMIT_PACKAGE_CDROM= Yes
+
+MODPY_SETUPTOOLS= Yes
+MODPY_PI= Yes
+
+COMPILER= base-clang
+
+MODULES= lang/python
+
+FLAVORS= python3
+FLAVOR?=
+
+LIB_DEPENDS= devel/protobuf
+
+RUN_DEPENDS+= www/py-beautifulsoup4${MODPY_FLAVOR} \
+ math/py-numpy${MODPY_FLAVOR} \
+ math/py-pandas${MODPY_FLAVOR} \
+ www/py-requests${MODPY_FLAVOR}
+
+.if !${FLAVOR:Mpython3}
+RUN_DEPENDS += devel/py-enum34${MODPY_FLAVOR}
+.endif
+
+
+MODPY_PYTEST= Yes
+TEST_DEPENDS= devel/py-coveralls${MODPY_FLAVOR} \
+ devel/py-test-cov${MODPY_FLAVOR}
+
+.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: distinfo
diff -N distinfo
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ distinfo 28 Apr 2019 18:52:37 -0000
@@ -0,0 +1,2 @@
+SHA256 (siphon-0.8.0.tar.gz) = FCXMAqgqQ0ymsC2fnFooOe7O5azofel8rCIpmLAYGvA=
+SIZE (siphon-0.8.0.tar.gz) = 224744
Index: pkg/DESCR
===================================================================
RCS file: pkg/DESCR
diff -N pkg/DESCR
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ pkg/DESCR 28 Apr 2019 18:52:37 -0000
@@ -0,0 +1,4 @@
+Siphon is a collection of Python utilities for downloading data from remote
data
+services. Much of Siphon's current functionality focuses on access to data
+hosted on a THREDDS Data Server. It also provides clients to a variety of
simple
+web services.
Index: pkg/PLIST
===================================================================
RCS file: pkg/PLIST
diff -N pkg/PLIST
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ pkg/PLIST 28 Apr 2019 18:52:37 -0000
@@ -0,0 +1,63 @@
+@comment $OpenBSD: PLIST,v$
+lib/python${MODPY_VERSION}/site-packages/siphon/
+lib/python${MODPY_VERSION}/site-packages/siphon-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/
+lib/python${MODPY_VERSION}/site-packages/siphon-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
+lib/python${MODPY_VERSION}/site-packages/siphon-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
+lib/python${MODPY_VERSION}/site-packages/siphon-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
+lib/python${MODPY_VERSION}/site-packages/siphon-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
+lib/python${MODPY_VERSION}/site-packages/siphon-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
+lib/python${MODPY_VERSION}/site-packages/siphon/__init__.py
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}_tools.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}_version.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}catalog.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}http_util.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}metadata.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}ncss.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}ncss_dataset.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}radarserver.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/${MODPY_PYCACHE}testing.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/_tools.py
+lib/python${MODPY_VERSION}/site-packages/siphon/_version.py
+lib/python${MODPY_VERSION}/site-packages/siphon/catalog.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/__init__.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}cdmremote.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}cdmremotefeature.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}cdmrfeature_pb2.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}coveragedataset.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}dataset.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}ncStream_pb2.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}ncstream.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/${MODPY_PYCACHE}xarray_support.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/cdmremote.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/cdmremotefeature.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/cdmrfeature_pb2.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/coveragedataset.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/dataset.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/ncStream_pb2.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/ncstream.py
+lib/python${MODPY_VERSION}/site-packages/siphon/cdmr/xarray_support.py
+lib/python${MODPY_VERSION}/site-packages/siphon/http_util.py
+lib/python${MODPY_VERSION}/site-packages/siphon/metadata.py
+lib/python${MODPY_VERSION}/site-packages/siphon/ncss.py
+lib/python${MODPY_VERSION}/site-packages/siphon/ncss_dataset.py
+lib/python${MODPY_VERSION}/site-packages/siphon/radarserver.py
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/__init__.py
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/${MODPY_PYCACHE}acis.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/${MODPY_PYCACHE}iastate.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/${MODPY_PYCACHE}igra2.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/${MODPY_PYCACHE}ndbc.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/${MODPY_PYCACHE}wyoming.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/acis.py
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/iastate.py
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/igra2.py
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/ndbc.py
+lib/python${MODPY_VERSION}/site-packages/siphon/simplewebservice/wyoming.py
+lib/python${MODPY_VERSION}/site-packages/siphon/testing.py
