On Wed, 1 May 2019 02:21:06 +0200
Charlene Wendling <[email protected]> wrote:

> On Mon, 29 Apr 2019 23:48:15 +0200
> Christian Weisgerber <[email protected]> wrote:
> 
> > Charlene Wendling:
> > 
> > > > > http://build-failures.rhaalovely.net/powerpc/last/net/toxcore.log
> > > > 
> > > > This port uses base-gcc, that doesn't recognise
> > > > "-Wno-c99-extensions".
> > 
> > This only disables a warning.
> > How about simply removing the "-Wno-c99-extensions"?
> 
> I'll try once my partial libcdio bulk is done and either report the
> log or propose another diff.

It's a bit more intrusive but it builds (: 

There are 3 consumers: net/toxic net/toxic,no_x11 net/utox

I've built them as well. Runtime is also fine.

OK?

Charlène.

> > -- 
> > Christian "naddy" Weisgerber
> > [email protected]
> > 
> 


Index: Makefile
===================================================================
RCS file: /cvs/ports/net/toxcore/Makefile,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 Makefile
--- Makefile    29 Apr 2019 11:46:07 -0000      1.4
+++ Makefile    2 May 2019 21:15:13 -0000
@@ -3,7 +3,7 @@
 COMMENT =              Tox client library
 
 V =                    0.2.3
-REVISION =             1
+REVISION =             2
 DISTNAME =             toxcore-$V
 
 GH_ACCOUNT =           TokTok
@@ -19,9 +19,6 @@ HOMEPAGE =            https://tox.chat/
 PERMIT_PACKAGE_CDROM = Yes
 
 WANTLIB = c config m opus pthread sodium vpx
-
-# "-Wno-c99-extensions" isn't recognized by base-gcc
-COMPILER =             base-clang ports-gcc
 
 MODULES =              devel/cmake
 
Index: patches/patch-CMakeLists_txt
===================================================================
RCS file: patches/patch-CMakeLists_txt
diff -N patches/patch-CMakeLists_txt
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-CMakeLists_txt        2 May 2019 21:15:13 -0000
@@ -0,0 +1,16 @@
+$OpenBSD$
+
+Allow building with base-gcc that doesn't recognise this option
+
+Index: CMakeLists.txt
+--- CMakeLists.txt.orig
++++ CMakeLists.txt
+@@ -171,7 +171,7 @@ if(NOT MSVC)
+     # Comma at end of enum is supported everywhere we run.
+     add_cxxflag("-Wno-c++98-compat-pedantic")
+     # TODO(iphydf): Stop using flexible array members.
+-    add_cxxflag("-Wno-c99-extensions")
++    #add_cxxflag("-Wno-c99-extensions")
+     # We're C-compatible, so use C style casts.
+     add_cxxflag("-Wno-old-style-cast")
+ 

Reply via email to