On Sat, May 04 2019, Edd Barrett <[email protected]> wrote: > Hi, > > On Sat, May 04, 2019 at 02:29:10PM +0200, Charlene Wendling wrote: >> +Index: ip/ffmpeg.c >> +--- ip/ffmpeg.c.orig >> ++++ ip/ffmpeg.c >> +@@ -62,6 +62,7 @@ struct ffmpeg_private { >> + AVFormatContext *input_context; >> + AVCodec *codec; >> + SwrContext *swr; >> ++ int stream_index; >> + >> + struct ffmpeg_input *input; >> + struct ffmpeg_output *output; > > ^ This patch seems redundant? I removed it and it still builds. > > ---8<--- > $ make port-lib-depends-check > ... > cmus-2.8.0(audio/cmus,-main): > Extra: ogg.6 vorbis.9 > --->8--- > > Seems fishy... I can play my vorbis files fine...
cmus dlopen's modules for input and output. Adding the affected libraries to WANTLIB-main makes sense so that a vorbis or ogg update triggers a signature change and an update, but adding a comment to explain the rationale would help. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
