On Sat, May 04 2019, Antoine Jacoutot <[email protected]> wrote:
> On Sat, May 04, 2019 at 02:26:12PM +0200, Remi Locherer wrote:
>> On Fri, May 03, 2019 at 08:55:40PM +0200, Jeremie Courreges-Anglas wrote:
[...]
>> > - use python2, needed by tests/dummyserver.py (previously SKIPPED
>> > because of the lack of "timeout" command)
[...]
>> +MODULES = lang/python
>> +MODPY_BUILDDEP = No
>> +MODPY_RUNDEP = No
>> +MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}
>
> Do we need to set MODPY_VERSION? It's default.
Not needed, technically. I thought it would be good to be explicit
since python is only used for tests, so it's unlikely to be spotted when
we switch to python3 by default.
On the other hand, there's a non-zero chance that librelp tests will
fully support python3 before the python3 switch happens in our tree.
I don't care much either way, I'll defer to Remi (maintainer) and you.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
