On Wed, May 08 2019, Kurt Mosiejczuk <[email protected]> wrote:
> On Wed, May 08, 2019 at 09:13:01PM +0200, Bj??rn Ketelaars wrote:
>> The recent update of py-tornado [0] seems to rely on py-futures, which is
>> currently listed in Makefile as TEST_DEPENDS.
>
> [...]
>
>> I grepped the source code of py-tornado and noticed that
>> concurrent.futures is imported at several places. Issue is easily fixed
>> by moving py-futures to RUN_DEPENDS.
>
>> OK?
>
> I did a quick test to make sure test still run properly when moving the
> DEPEND. It's fine.
Yeah and in case I'm not the only one: there's a
TEST_DEPENDS = ${RUN_DEPENDS}
line earlier in the Makefile, so make test still triggers the
installation of py-futures. It would make sense to move all the
*_DEPENDS line next to each others.
> OK kmos
Also ok jca@
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
