On Sat, May 11, 2019 at 07:19:22PM +0200, Marc Espie wrote: > On Sat, May 11, 2019 at 01:22:58AM +0200, Antoine Jacoutot wrote: > > On Sat, May 11, 2019 at 01:08:29AM +0200, Christian Weisgerber wrote: > > > Here's a draft for CONFIGURE_STYLE=autoreconf. No man page parts > > > yet. > > As far as the basic infrastructure changes go, things look fine. > This makes for one new variable to document (AUTORECONF) which > is nice. > > Haven't seen any problems there. > > > Oh for sure we want to default to 'autoreconf -fi'. > > But we need to be able to also set it to autogen.sh if needed. Because > > sometimes > > autoreconf will not work before some other autoshit are run first (or stuff > > like gettextize etc.) which autogen.sh takes care of. > > Anything needed besides setting AUTORECONF on those ports ?
Nope. > > > He has also raised two questions: > > > * Which autotools dependencies do we want to enable by default? > > > I put autoconf and automake there, but libtoolize (from libtool) > > > is often needed, too. Sometimes autopoint (from gettext-tools) > > > is required. > > > > As far as I am concerned I don't mind enforcing these build dependencies. > > Beware of build loops though. If you add these unconditionally, then > you can't benefit from autoreconf anywhere in the build path leading > to autopoint or libtoolize > > For now, that's just > archivers/xz > converters/libiconv > devel/autoconf/2.67 > devel/gettext > devel/gettext-tools > devel/help2man > devel/libtool > devel/metaauto > > So, it looks fine for now... > Let's assume gnu isn't going to do something stupid in the near > future... > > (as for dpb dependencies proper, all things that take time building > among these of these are critical enough that they get to be built > first in any case) > > > > * Should we set NOCONFIGURE=1 in the environment by default, as > > > many autogen.sh scripts use this in order not to run configure? > > > > I am in favor of this. Otherwise we end up running configure twice... > > To be clear, you're talking about > AUTOCONF_ENV += NOCONFIGURE=1 > if CONFIGURE_STYLE is autoreconf, right ? Yes :-) -- Antoine
