On Sat, 18 May 2019 01:09:00 +0100
Stuart Henderson <[email protected]> wrote:

> On 2019/05/17 23:13, Charlene Wendling wrote:
> > Ping :) 
> > 
> > On Tue, 7 May 2019 00:04:05 +0200
> > Charlene Wendling <[email protected]> wrote:
> > 
> > > 
> > > Here is an update for XML::RSS.
> > > 
> > > What's new upstream [0]:
> > > 
> > > - Convert to Dist::Zilla
> > > - Add Travis-CI support
> > >   (yup, only distribution changes)  
> > > 
> > > What's new in the port: 
> > > 
> > > - drop devel/p5-DateTime from RUN_DEPENDS, as DateTime isn't
> > >   used directly in the code
> > > - make use of TEST_POD instead of pulling dependencies
> > > - don't use 'rm -f' as a mean to zap something from PLIST but
> > >   @comment instead (rationale here [1])
> > >   TIL that update-plist(1) won't add these .orig files anyway,
> > >   just issuing a warning
> 
> I agree with bluhm about rm -f where it's needed, but I am happy
> with rm (no -f) instead.
> 
> But in this case with .orig files which update-plist doesn't include
> anyway (which is relatively new for update-plist), I'd prefer to just
> leave them out completely. But I don't really object to @comment.
> OK either way.

I'll remove them, in fact i didn't know if it was better to suppress
warnings or not.

Thanks for reviewing these ports :)

Charlène.

> >  share/examples/p5-XML-RSS/1.0/rss1.0.rdf
> >  share/examples/p5-XML-RSS/1.0/slash.rdf
> >  share/examples/p5-XML-RSS/1.0/update_rss_1.0.pl
> > +@comment share/examples/p5-XML-RSS/1.0/update_rss_1.0.pl.orig
> >  share/examples/p5-XML-RSS/2.0/
> >  share/examples/p5-XML-RSS/2.0/flickr-rss-with-both-desc-and-media-desc.xml
> >  
> > share/examples/p5-XML-RSS/2.0/rss-2.0-sample-from-rssboard-multiple-skip-days-and-hours.xml
> > @@ -40,4 +48,5 @@ share/examples/p5-XML-RSS/convert.pl
> >  share/examples/p5-XML-RSS/create_rss_multiple.pl
> >  share/examples/p5-XML-RSS/rss2html.pl
> >  share/examples/p5-XML-RSS/rss_info.pl
> > +@comment share/examples/p5-XML-RSS/rss_info.pl.orig
> >  share/examples/p5-XML-RSS/update_rss.pl
> > 

Reply via email to