On 2019/07/12 00:10, Thomas Frohwein wrote:
> Hi,
>
> The diff below removes --without-pthreads from net/libunbound. The
> reason why I'm proposing is that this way, a WIP draft of monero (the
> cryptocurrency) works which otherwise segfaults if libunbound is
> without pthread support.
>
> There are only 2 ports that depend on it - security/gnutls and
> telephony/asterisk. I have tested gnutls's gnutls-cli and certtool
> (with a few examples from the manpage) without any issues with
> libunbound pthread support. I'm not sure how to test asterisk without
> owning a SIP phone.
>
> I'm happy to do more testing if desired if someone can give me pointers
> to the best way to test the affected ports. Or let me know why it may
> be a bad idea to enable pthreads here...
I'm updating a machine so I can test asterisk with this.
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/libunbound/Makefile,v
> retrieving revision 1.5
> diff -u -p -r1.5 Makefile
> --- Makefile 29 Jun 2019 13:49:41 -0000 1.5
> +++ Makefile 12 Jul 2019 05:59:11 -0000
> @@ -4,6 +4,7 @@ COMMENT= validating DNS resolver library
>
> DISTNAME= unbound-1.9.2
> PKGNAME= lib${DISTNAME}
> +REVISION= 0
>
> SHARED_LIBS += unbound 4.1 # 9.0
>
> @@ -30,7 +31,6 @@ CONFIGURE_ARGS+= \
> --with-ssl=/usr \
> --with-libevent=/usr \
> --with-libexpat=/usr \
> - --without-pthreads \
> --without-pythonmodule \
> --with-chroot-dir=/var/unbound \
> --with-pidfile="" \
>
It needs pthread in WANTLIB now, plus I'd prefer to explicitly set
"--with-pthreads" rather than leave it up to autodetection, so this
is the diff I'll test:
Index: Makefile
===================================================================
RCS file: /cvs/ports/net/libunbound/Makefile,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile
--- Makefile 29 Jun 2019 13:49:41 -0000 1.5
+++ Makefile 12 Jul 2019 13:30:15 -0000
@@ -4,6 +4,7 @@ COMMENT= validating DNS resolver library
DISTNAME= unbound-1.9.2
PKGNAME= lib${DISTNAME}
+REVISION= 0
SHARED_LIBS += unbound 4.1 # 9.0
@@ -16,7 +17,7 @@ MAINTAINER= Stuart Henderson <sthen@open
# BSD
PERMIT_PACKAGE= Yes
-WANTLIB += crypto event ssl
+WANTLIB += crypto event pthread ssl
MASTER_SITES= https://www.unbound.net/downloads/
@@ -30,7 +31,7 @@ CONFIGURE_ARGS+= \
--with-ssl=/usr \
--with-libevent=/usr \
--with-libexpat=/usr \
- --without-pthreads \
+ --with-pthreads \
--without-pythonmodule \
--with-chroot-dir=/var/unbound \
--with-pidfile="" \
