On 2019/07/14 18:52, Kurt Mosiejczuk wrote: > On Sun, Jul 14, 2019 at 11:31:06PM +0100, Stuart Henderson wrote: > > On 2019/07/14 18:18, Kurt Mosiejczuk wrote: > > > > I've got an OK from edd for this new port. > > > > Can I get a 2nd OK for import? > > > > Once this is in the picard update can go in. > > > > (port attached again for reference) > > > If I read the python code right, this tries to load libdiscid.so.0 > > which works for now, but will fail if the libdiscid major is bumped, I > > think that should be changed to just load libdiscid.so on OpenBSD. > > I patched it to try to load libdiscid.so now. Patch included in this new > tarball. Port still passes its tests with the change. > > > DESCR is a bit light.. > > Oops. Yes. Portgen will do that. Almost might be better if it left it blank > so portcheck would yell about it being missing rather than having the same > thing as COMMENT in the Makefile. > > --Kurt
I think that'll do. OK to import. (Of course things may still not work properly if a change is made to libdiscid that requires the major being bumped but at least there's a chance this way!)
