ping
On Wed, Jul 10, 2019, at 11:06 PM, Thomas Frohwein wrote:
> I tested the consumers of physfs with 3.0.2 (except games/love because I
> have no suitable ROMs/cartridges) and found no regression on brief
> testing. As mentioned before, dxx-rebirth that is BROKEN on clang arches
> since the clang update can be bumped to a newer version that requires
> physfs-3.0.2 and then builds and runs again.
>
> games/blobby segfaults with both physfs-3.0.1p0 and 3.0.2. I have
> attached a backtrace from the corefile after building blobby with -O0
> and -g. It's C++ and may need a closer look to figure out why it's
> apparently broken (on both my amd64/Ryzen/amdgpu desktop and my
> amd64/Intel Skylake laptop).
>
> List of all consumers of physfs and sdl-sound (which depends on
> physfs):
> devel/sdl-sound
> games/barony
> games/blobby
> games/colobot/colobot
> games/hedgewars
> games/lincity-ng
> games/love
> games/neverball
> games/solarus/solarus
> games/sumwars
> games/warzone2100
> emulators/dosbox
> games/gargoyle
> games/roadfighter
>
> On Mon, Jun 24, 2019 at 11:05:06PM +0200, Klemens Nanni wrote:
> [...]
> > > Add NO_TEST=Yes while here.
> > There is a test program in ${WRKSRC}/test/.
>
> That is a very weird test program - test_physfs is installed into
> $PREFIX/bin, and it's an interactive prompt to open/mount/list
> supported archives. It's much more an interactive version of the tool
> than a unit test suite. I guess that's why this wasn't addressed as a
> test previously.
> I see the following options:
> 1. We consider test_physfs just part of the installed program and set
> NO_TEST=Yes.
> 2. We consider it an interactive test of the library functions. This
> could potentially be set up with a test target that executes it in
> WRKBUILD. I don't think this will be very useful given how unwieldy and
> non-automatic it is.
> (There's a Debian man page which doesn't help much to decide this IMO
> [1].)
>
> [...]
> > HOMEPAGE has TLS.
>
> Good catch, I added that!
>
> > Please adapt the license marker.
>
> My bad, fixed along with the HOMEPAGE in new diff below
>
> [1]
> https://manpages.debian.org/experimental/libphysfs-dev/test_physfs.1.en.html
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/physfs/Makefile,v
> retrieving revision 1.14
> diff -u -p -r1.14 Makefile
> --- Makefile 11 Dec 2018 21:30:29 -0000 1.14
> +++ Makefile 11 Jul 2019 03:58:59 -0000
> @@ -2,21 +2,23 @@
>
> COMMENT= library to provide abstract access to various archives
>
> -DISTNAME= physfs-3.0.1
> -REVISION= 0
> +DISTNAME= physfs-3.0.2
> CATEGORIES= devel
> MASTER_SITES= ${HOMEPAGE}downloads/
> EXTRACT_SUFX= .tar.bz2
>
> SHARED_LIBS= physfs 3.0
>
> -HOMEPAGE= http://icculus.org/physfs/
> +HOMEPAGE= https://icculus.org/physfs/
> +MAINTAINER= Thomas Frohwein <t...@openbsd.org>
>
> # ZLib
> -PERMIT_PACKAGE_CDROM= Yes
> +PERMIT_PACKAGE= Yes
>
> -WANTLIB= c curses pthread readline z
> +WANTLIB= c curses pthread readline
>
> MODULES= devel/cmake
> +
> +NO_TEST= Yes
>
> .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/physfs/distinfo,v
> retrieving revision 1.8
> diff -u -p -r1.8 distinfo
> --- distinfo 11 Jul 2018 16:05:14 -0000 1.8
> +++ distinfo 11 Jul 2019 03:58:59 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (physfs-3.0.1.tar.bz2) = t3ufhTFo2WNqRPdfyjcrNjEG9S14nRii93Y5e/EX8vE=
> -SIZE (physfs-3.0.1.tar.bz2) = 194638
> +SHA256 (physfs-3.0.2.tar.bz2) = ME33YgbWM99TYOc4sTjJToLM8IblC6hPRW0/hDL5+GM=
> +SIZE (physfs-3.0.2.tar.bz2) = 194888
>
> Attachments:
> * backtrace-O0-g.txt
--
tfrohw...@fastmail.com
PGP Public Key: https://pgp.mit.edu/pks/lookup?op=get&search=0xE1A22D58D20C6D22
