I noticed that this was failing tests when reviewing a different port
update and a simple update solved it.

I did add some optional TEST_DEPENDS to avoid skipping tests, although I
think passing tests require the p5-SQL-Statement update (or something
related) that I committed just now.

I stole starting memcached magic from devel/p5-Cache-Memcached, and it
seemed to work, although I assume someone testing this on a machine
already running memcached will have issues with either of these things.
Not sure what the policy is there.

The old version should have been broken completely without the update
according to the changelog, so it seems likely nobody actually uses
Jifty, or at least Jifty::DBI so maybe it's better just to remove the
whole thing?

https://metacpan.org/changes/distribution/Jifty-DBI

It also removes the patch in preference for adding  `--skipdeps` to
CONFIGURE_ARGS so it doesn't try to  auto install the dependencies.

Comments, OK?

Index: Makefile
===================================================================
RCS file: /cvs/ports/databases/p5-Jifty-DBI/Makefile,v
retrieving revision 1.15
diff -u -p -r1.15 Makefile
--- Makefile    12 Jul 2019 20:43:57 -0000      1.15
+++ Makefile    18 Aug 2019 21:00:05 -0000
@@ -5,7 +5,7 @@ COMMENT=        database OO schema for Jifty
 MODULES=       cpan
 PKG_ARCH=      *
 
-DISTNAME=      Jifty-DBI-0.68
+DISTNAME=      Jifty-DBI-0.78
 CATEGORIES=    databases www
 
 # perl
@@ -35,5 +35,20 @@ RUN_DEPENDS= databases/p5-DBI \
 
 # a lot of tests will be skipped without DB connections
 TEST_DEPENDS=databases/p5-DBD-SQLite
+
+# Additional modules to avoid skipping tests
+TEST_DEPENDS+= devel/p5-Time-Duration \
+               devel/p5-Time-Duration-Parse \
+               devel/p5-YAML-Syck \
+               misc/memcached
+
+# Don't let dependencies AutoInstall
+CONFIGURE_ARGS=--skipdeps
+
+pre-test:
+       ${LOCALBASE}/bin/memcached -d -l 127.0.0.1 -p 11211
+
+post-test:
+       pkill memcached
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/databases/p5-Jifty-DBI/distinfo,v
retrieving revision 1.5
diff -u -p -r1.5 distinfo
--- distinfo    18 Jan 2015 03:13:03 -0000      1.5
+++ distinfo    18 Aug 2019 21:00:05 -0000
@@ -1,2 +1,2 @@
-SHA256 (Jifty-DBI-0.68.tar.gz) = B/uAzwzM3hLMdvukgw+NoCJC2ki7jRcCeN7oNIt9Op8=
-SIZE (Jifty-DBI-0.68.tar.gz) = 163841
+SHA256 (Jifty-DBI-0.78.tar.gz) = lkXKepeqkIK5ge1esCrS279sEH1OYM4eTHXavRombLg=
+SIZE (Jifty-DBI-0.78.tar.gz) = 168399
Index: patches/patch-Makefile_PL
===================================================================
RCS file: patches/patch-Makefile_PL
diff -N patches/patch-Makefile_PL
--- patches/patch-Makefile_PL   20 Apr 2011 08:12:21 -0000      1.3
+++ /dev/null   1 Jan 1970 00:00:00 -0000
@@ -1,34 +0,0 @@
-$OpenBSD: patch-Makefile_PL,v 1.3 2011/04/20 08:12:21 jasper Exp $
---- Makefile.PL.orig   Wed Apr 20 10:05:15 2011
-+++ Makefile.PL        Wed Apr 20 10:06:47 2011
-@@ -3,6 +3,7 @@ name ('Jifty-DBI');
- license ('perl');
- version_from('lib/Jifty/DBI.pm');
- perl_version('5.8.3');
-+=pod
- requires('Cache::Simple::TimedExpiry' => '0.21');
- requires('Class::Accessor::Fast' => 0);
- requires('Class::Data::Inheritable');
-@@ -24,10 +25,14 @@ requires('UNIVERSAL::require' => 0.11);
- requires('Scalar::Defer' => 0.10);
- requires('version');
- #requires('Class::Trigger');
-+=cut
- build_requires('Test::More' => 0.52);
- build_requires('Test::Warn' => 0.10);
-+=pod
- build_requires('DBD::SQLite' => 1.14);
-+=cut
- no_index directory => 'ex';
-+=pod
- features( 
-     'Memcached support' => [
-         -default => 1,
-@@ -47,6 +52,7 @@ features( 
-         'URI' => '',
-     ],
- );
-+=cut
- auto_install();
- &WriteAll;
- 

Reply via email to