On Mon, 19 Aug 2019 22:39:34 +0200
Jeremie Courreges-Anglas wrote:
> On Mon, Aug 19 2019, Jeremie Courreges-Anglas <[email protected]> wrote:
> > On Mon, Aug 19 2019, Charlene Wendling <[email protected]> wrote:
> >>> http://build-failures.rhaalovely.net/sparc64/2019-08-15/devel/woboq_codebrowser.log
> >> (same thing for macppc, but latest full bulk report is archived)
> >>
[...]
> >>
> >> OK?
> >
> > yep, but obvious comment is obvious...
>
> Thinking more about it...
It's more explicit that my comment, and it works fine as well.
I attached the diff below.
[...]
> >> Index: Makefile
> >> ===================================================================
> >> RCS file: /cvs/ports/devel/woboq_codebrowser/Makefile,v
> >> retrieving revision 1.1.1.1
> >> diff -u -p -u -p -r1.1.1.1 Makefile
> >> --- Makefile 22 Jun 2019 12:16:56 -0000 1.1.1.1
> >> +++ Makefile 19 Aug 2019 18:25:27 -0000
> >> @@ -26,6 +26,9 @@ PERMIT_PACKAGE = Yes
> >> # uses pledge()
> >> WANTLIB = ${COMPILER_LIBCXX} c m
> >>
> >> +# required to use ports-clang as CXX on base-gcc arches
> >> +COMPILER = base-clang ports-clang
> >> +
> >> MODULES = devel/cmake \
> >> lang/clang
>
> COMPILER and MODULES = lang/clang look a bit redundant. I'd suggest
> using something more explicit:
>
> COMPILER = base-clang ports-clang
> BUILD_DEPENDS = devel/llvm
> RUN_DEPENDS = devel/llvm
>
> like done in devel/include-what-you-use.
>
> >> RUN_DEPENDS = devel/llvm
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE
> 1524 E7EE
>
Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/woboq_codebrowser/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 Makefile
--- Makefile 22 Jun 2019 12:16:56 -0000 1.1.1.1
+++ Makefile 19 Aug 2019 20:53:27 -0000
@@ -26,8 +26,10 @@ PERMIT_PACKAGE = Yes
# uses pledge()
WANTLIB = ${COMPILER_LIBCXX} c m
-MODULES = devel/cmake \
- lang/clang
+COMPILER = base-clang ports-clang
+
+MODULES = devel/cmake
+BUILD_DEPENDS = devel/llvm
RUN_DEPENDS = devel/llvm
NO_TEST = Yes
