Hi,
On Sun, Sep 15, 2019 at 01:40:35PM +0100, Stuart Henderson wrote:
> > > -BUILD_DEPENDS+= devel/gobject-introspection
> > > +# devel/boost only as build dependency, because poppler uses
> > > +# header-only classes (from boost/containers/small_vector.hpp).
> > > +BUILD_DEPENDS+= devel/boost \
> > > + devel/gobject-introspection
> >
> > Don't you need to adjust RUN_DEPENDS for API dependency?
> >
> > $ rg -i boost /usr/local/include/poppler
> > /usr/local/include/poppler/poppler-config.h
> > 114:/* Use header-only classes from Boost in the Splash backend */
> > 115:#ifndef USE_BOOST_HEADERS
> > 116:#define USE_BOOST_HEADERS 1
> >
> > /usr/local/include/poppler/splash/SplashXPathScanner.h
> > 30:#ifdef USE_BOOST_HEADERS
> > 31:#include <boost/container/small_vector.hpp>
> > 103:#ifdef USE_BOOST_HEADERS
> > 104: typedef boost::container::small_vector<SplashIntersect, 4>
> > IntersectionLine;
> > 122:#ifdef USE_BOOST_HEADERS
> > 123: typedef boost::container::small_vector<SplashIntersect, 4>
> > IntersectionLine;
> >
>
> Oh, good catch.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/print/poppler/Makefile,v
> retrieving revision 1.147
> diff -u -p -r1.147 Makefile
> --- Makefile 14 Sep 2019 20:14:26 -0000 1.147
> +++ Makefile 15 Sep 2019 12:40:10 -0000
> @@ -6,7 +6,7 @@ COMMENT-utils= PDF conversion tools and
>
> V= 0.80.0
> DISTNAME= poppler-$V
> -REVISION-main= 0
> +REVISION-main= 1
> CATEGORIES= print
> PKGNAME-main= poppler-$V
> PKGNAME-utils= poppler-utils-$V
> @@ -43,13 +43,16 @@ MODULES= devel/cmake
>
> MODULES+= x11/qt5
>
> -# devel/boost only as build dependency, because poppler uses
> -# header-only classes (from boost/containers/small_vector.hpp).
> +# devel/boost only as build+run dependency, poppler uses
> +# header-only classes (from boost/containers/small_vector.hpp)
> +# which are pulled in by installed headers, but does not use
> +# boost libraries.
> BUILD_DEPENDS+= devel/boost \
> devel/gobject-introspection
>
> RUN_DEPENDS-main= \
> - print/poppler-data>=0.4.7
> + print/poppler-data>=0.4.7 \
> + devel/boost
>
> LIB_DEPENDS-main=${MODGCC4_CPPLIBDEP} \
> converters/libiconv \
ok.
Ciao,
Kili
