On 2019/09/12 09:13, Martijn van Duren wrote:
> ping
>
> On 9/5/19 3:13 PM, Martijn van Duren wrote:
> > On 8/24/19 6:29 AM, Martijn van Duren wrote:
> >> $ cat libopensmtpd/pkg/DESCR
> >> libopensmtpd is an libevent based library which allows for easy writing
> >> of opensmtpd filter applications in C.
> >> $
> >>
> >> This is required for filter-dnsbl and filter-dkim.
> >>
> >> Since I'm not too familiar with ports I would like to pay special
> >> attention to the Makefile of both the port as well as the source.
> >>
> >> Also, I currently host the release tarballs at my personal server, which
> >> I also use for generic other stuff and might not always be available.
> >> If someone from the ports team has a more stable location to host the
> >> release tarballs let me know.
> >>
> >> martijn@
> >>
> > Updated diff based on recent smtpd changes.
> > I haven't changed the version number since it isn't imported in ports
> > yet.
> >
> > Questions above still remain.
> >
> > Now to be placed in mail/openstmpd-filters. Requires additional diff
> > to prevent PKGNAME to be overwritten.
> >
> > Index: Makefile.inc
> > ===================================================================
> > RCS file: /cvs/ports/mail/opensmtpd-filters/Makefile.inc,v
> > retrieving revision 1.1
> > diff -u -p -r1.1 Makefile.inc
> > --- Makefile.inc 4 Sep 2019 12:27:42 -0000 1.1
> > +++ Makefile.inc 5 Sep 2019 13:12:09 -0000
> > @@ -1,6 +1,6 @@
> > # $OpenBSD: Makefile.inc,v 1.1 2019/09/04 12:27:42 martijn Exp $
> >
> > -PKGNAME = opensmtpd-filter-${FILTER_NAME}-${V}
> > +PKGNAME ?= opensmtpd-filter-${FILTER_NAME}-${V}
> >
> > MODGO_TYPE = bin
> > MODGO_BINDIR = libexec/smtpd
> >
>
port doesn't honour CC - set this: MAKE_FLAGS= CC="${CC}"
trim COMMENT a bit, we don't usually start with a/the or start with
caps. I'd just go for e.g. "library for writing opensmtpd filters"
gcc objects to this:
opensmtpd.c:1967:13: warning: 'port' may be used uninitialized in this function
[-Wmaybe-uninitialized]
port[-1] = ':';
~~~~~~~~~^~~~~
start with "SHARED_LIBS= opensmtpd 0.0" and the version number needs to
be under ports control; changing that var in the Makefile must cause the
built library version to change. the version number is available in
LIBopensmtpd_VERSION in the ports Makefile which can then be passed into
the build via MAKE_FLAGS / MAKE_ENV.
