On Wed, Oct 2, 2019, at 09:28, Travis Cole wrote: > On Wed, Oct 2, 2019, at 01:11, Stuart Henderson wrote: > > On 2019/10/01 22:01, Travis Cole wrote: > > > > > lua-compat-5.3 doesn't install any headers, and no other PLIST file in > > > ports has it either. > > > > > > I'm not sure if it's best to keep the deps dir? or are we talking about > > > modifying lua-compat53 to install > > > those headers? > > > > Yes that would need lua-compat53 to install the header (and it should also > > install the C file I think), but it will need to avoid adding a conflict > > between the packages for the two supported Lua versions (lua-compat53 and > > lua52-compat53). > > > > > Or is there a simpler option that I'm missing? > > > > The simpler option is to use the bundled one. > > > > I've CC'd lua-compat53 maintainer - fcambus, do you think it's worth > > complicating the lua-compat53 port to add this? > > > > Here's a diff on top of yours. I haven't touched the lua-compat53 parts > > yet but otherwise: > > > > - zap stray <space> on PKGNAME line > > - put WANTLIB in the right place > > - don't BUILD_DEPENDS on cmake or set SEPARATE_BUILD, the cmake module > > already does this > > - standard case for NO_TEST is Yes not YES > > > > Thanks for this diff, I can send an updated tar after work today. In 8 or so > hours. > > Now I remember why I didn't have SEPARATE_BUILD in there in the first place... > But didn't realize I could also leave out cmake. >
Attached is a tar of the luv port with Stuart's diff applied.
luv.tar.gz
Description: application/gzip
