Hi,

On Fri, 27 Sep 2019 13:52:49 +0200
Rafael Sadowski wrote:

[...]
> 
> Please find attached a re-write of your proposal.
> 
> - move to math, devel to full and I see math is a better category.
> - Drop do-test, cmake will handle it for use.
> - Add WANTLIB

> - Drop Compiler, builds fine with all compilers. No C++11

Yes, but there are platform-specific quirks that ports-gcc handles
gracefully, unlike the old base one ;)

That's why portcheck(1) yells if COMPILER_LIBCXX is in WANTLIB and
no COMPILER line with at least ports-gcc is set [0].

The build fails on macppc:

>> https://bin.charlenew.xyz/double-conversion.fail.log

Once COMPILER is brought back, it works [1], and 'make test' as well.

OK?

Charlène.


[0] https://marc.info/?l=openbsd-ports&m=156561626006156&w=2
[1] https://bin.charlenew.xyz/double-conversion.working.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/math/double-conversion/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 Makefile
--- Makefile    17 Oct 2019 19:53:58 -0000      1.1.1.1
+++ Makefile    17 Oct 2019 23:01:37 -0000
@@ -15,6 +15,8 @@ PERMIT_PACKAGE=       Yes
 
 WANTLIB += ${COMPILER_LIBCXX} m
 
+COMPILER =             base-clang ports-gcc
+
 MODULES =              devel/cmake
 
 CONFIGURE_ARGS +=      -DBUILD_SHARED_LIBS=ON \

Reply via email to