On 2019/10/28 23:29, Anthony J. Bentley wrote:
> Hi,
> 
> Henning sent these ports a few months back. I've attached revised
> versions to this mail; they needed only minor cleanup.
> 
> net/p5-Net-WebSocket-Server

- cc'ing afresh1 for comment, but rather than listing devel/p5-Test-Pod and
devel/p5-Test-Pod-Coverage in TEST_DEPENDS the usual approach in cpan ports
seems to be "MAKE_ENV= TEST_POD=Yes" which adds the deps automatically

> net/p5-Protocol-WebSocket

- drop BUILD_DEPENDS, use CONFIGURE_STYLE = modbuild tiny

> security/p5-Crypt-LE

- drop p5-JSON dep; it's unused; Crypt::LE diverts all JSON via
JSON::MaybeXS which depends on Cpanel::JSON::XS and uses it preferentially

- maybe worth adding a HOMEPAGE? the cpan meta just has https://do-know.com
and there's also https://zerossl.com/, but one of these might be better ..
https://do-know.com/guides/blog-Get-free-SSL-Certificates-with-Perl.html
https://github.com/do-know/Crypt-LE

> security/p5-Crypt-PKCS10

- outdated - please bump to 2.001 (straightforward update, no big changes)

- s/PERMIT_PACKAGE_CDROM/PERMIT_PACKAGE/

- definitely missing a dep on converters/p5-Convert-ASN1

- also needs either security/p5-Crypt-OpenSSL-DSA or
security/p5-Crypt-OpenSSL-RSA or Crypt::PK::ECC (not ported) to do
anything; maybe add a run dep on security/p5-Crypt-OpenSSL-RSA as that's
still what most people will need?

> security/p5-Crypt-X509

already in tree

> I'm told these are blockers for HTTPS on open{ntp,bgp}d.org.

sounds fair to me, cert verification is often more sane if you can use
DNS-01.

Reply via email to