On 2019/11/03 14:57, Klemens Nanni wrote: > On Sun, Nov 03, 2019 at 12:17:13PM +0100, Jeremie Courreges-Anglas wrote: > > I'm sitting on a few changes in devel/git since some time already. > Thanks, I never noticed these until now. > > > - nghttp2 should not be listed here IMO. It really is a dep of libcurl, > > git itself doesn't use directly the nghttp API. > This might just be another remnant just like the recent removal of rsync > as RDEP.
This happens a few times, people add nghttp2 as LIB_DEPENDS when it's often not used by the port itself, only by libcurl. (Some programs do use nghttp2 directly, including snort and wireshark, but this is not so common). > > - sysctl(HW_PHYSMEM) wants an int. That doesn't work well if you have > > a decent amount or ram. What doesn't work well either is storing that > > int in the first bytes of an uninitialized int64_t stack variable. > > Let's properly use HW_PHYSMEM64 instead. I have left the HW_PHYSMEM > > code path so that the diff can be pushed upstream as-is without too > > many questions, but I'm not sure it makes much sense. > HW_PHYSMEM64 should really be used unconditionally, no? Can we actually > reach the case where HAVE_BSD_SYSCTL and HW_PHYSMEM are defined but > HW_PHYSMEM64 is not? What about other BSDs? I think both should be left, FreeBSD doesn't have HW_PHYSMEM64.
