On 2019/11/03 10:29, Lucas Raab wrote: > On Fri, Nov 01, 2019 at 09:07:31PM +0100, Klemens Nanni wrote: > > On Fri, Nov 01, 2019 at 02:44:02PM -0500, Lucas Raab wrote: > > > Updated to make it Python 3 only since the pcsc-lite depends is Python > > > 3 only > > PKGNAME should MODPY_PY_PREFIX instead of "py-".
Could be either way, py- will be replaced by python.port.mk anyway. > > DESCR should be a proper sentence, the current one is the same as > > COMMENT really. > > > > *Panel.py and diag.py which you install through PLIST use wxPython which > > is tracked as dependency in setup.py, but you lack an RDEP for that. > > Did you test the GUI functionality? Should it be installed? > > I hadn't tested the GUI functionality. To be honest, I've never used it > on Linux distros either. pyscard seems to be a common dependency for > other applications, but I've never seen the GUI used. I'm fine with > removing the relevant lines from the PLIST. That being said, there's no > such thing as an optional depends where the reference to wxPython could > be placed. Would it be a bad practice to leave the files there if > someone were to have wxPythong installed? Or is it better to simply not > install the files until somone comes asking for them? We do have a few things where an optional dependency is mentioned in a pkg-readme or I think even just DESCR. I'm not averse to that for some functionality which is rarely used (otherwise the port could use multi-packages but that seems overkill here).
