On Thu, Nov 07, 2019 at 10:42:37AM +0200, Kurt Mosiejczuk wrote:
> Python 3.8.0 had its final release. Here is a diff to add it to our tree.
> It doesn't change the default python3 yet, this is just to make it easier
> for folks who want to test Python 3.8 before we switch.
>
> Note that they have dropped the "m" from the .so file (and the python3.8m
> program). It is mentioned in the release notes.
Then i think this bit is wrong, no ?
> +SHARED_LIBS = python3.8m 0.0
according to what we have in tree:
[09:55] c64:~/ $grep -r ^SHAR /usr/ports/lang/python/
/usr/ports/lang/python/2.7/Makefile:SHARED_LIBS = python2.7 0.0
/usr/ports/lang/python/3.7/Makefile:SHARED_LIBS = python3.7m 0.0
[09:55] c64:~/ $grep -r @lib /usr/ports/lang/python/
/usr/ports/lang/python/2.7/pkg/PLIST-main:@lib
lib/libpython2.7.so.${LIBpython2.7_VERSION}
/usr/ports/lang/python/3.7/pkg/PLIST-main:@lib
lib/libpython3.7m.so.${LIBpython3.7m_VERSION}
> + # Version number of Python's own shared library file.
> + AC_SUBST(SOVERSION)
> +-SOVERSION=1.0
> ++SOVERSION=${LIBpython3.8m_VERSION}
So that's a contraption which applies the SHARED_LIBS version to the real
library here ?
> +@comment lib/libpython3.8m.so
did they reallly drop that m ? :) that line seems too up in the PLIST,
shouldnt it join those (or be removed ?):
> +@comment lib/libpython3.8.so
> +@lib lib/libpython3.8.so.${LIBpython3.8_VERSION}
LIBpython3.8_VERSION doesnt exist if python3.8 isnt in SHARED_LIBS.
Not saying all those are real issues, you might know more than me how
this python port works, but those bits looked suspicious to me :)
Landry
