On Sun, 08 Dec 2019 at 13:53:40 -0800, Andrew Hewus Fresh wrote: > On Sun, Dec 08, 2019 at 11:42:50AM -0700, Aaron Bieber wrote: > > Here is a diff that adds go support in portgen(1). It's a combination > > of diffs from my self and afresh1@. There are a few issues, but on the > > whole this is the direction I think we should take with regard to > > porting Go application. > > > > The biggest issue with the diff is it's inability to cope with the way > > Go escapes[1] uppercase letters in URLs. This means that this > > implementation can't package things like "github.com/gohugoio/hugo" as > > it has some dependencies like: "github.com/BurntSushi/toml". > > I would like to see this committed, so OK afresh1@, but some of the > changes are mine, so would definitely like to hear about regressions. > > I thought I had mailed out the Port.pm changes already, but it seems I > didn't actually do that. I think that should go in separately, and can > probably commit them on Thursday or so. The diff Aaron posted is > missing a bit of cleanup to Dependency.pm related to the improvements to > formatting, so the full patch for that is attached as: > > portgen-multi_value_values.patch
Tested with perl, ruby and python ports. No regress as far as building goes. I did notice that at least BUILD_DEPENDS becomes "unaligned". Before: BUILD_DEPENDS = devel/p5-Module-Build>=0.28 RUN_DEPENDS = www/p5-CGI \ After: BUILD_DEPENDS = devel/p5-Module-Build>=0.28 RUN_DEPENDS = www/p5-CGI \ (spaces used above to preserve look) > > I do have a couple other patches out looking for OKs, or at least > "doesn't seem to break anything" reports. > > This should detect ports that need FIX_EXTRACT_PERMISSIONS and set it: > portgen-fix_extract_permissions.patch > https://marc.info/?l=openbsd-ports&m=157454704431952&w=2 This seem fine. OK abieber@ > > Then one that looks up existing ports by "stem" instead of the current > heuristic. The worry here would be finding the "wrong" existing port, > but with this new way it should be easier to munge things and detect > more existing ports if necessary. > > portgen-lookup_existing_ports_by_stem.patch > https://marc.info/?l=openbsd-ports&m=157515508030392&w=2 > This one doesn't seem to cause issues so OK from me, it would be super cool if someone else could test it though! :D
