On Mon, 16 Dec 2019 at 14:56:53 +0000, Stuart Henderson wrote:
> On 2019/12/16 07:32, Aaron Bieber wrote:
> > On Mon, 16 Dec 2019 at 11:18:24 +0100, karlis.mikels...@lf.lv wrote:
> > > Hello,
> > > 
> > > Please find attached port for CFSSL latest stable version:
> > > "CFSSL is CloudFlare's PKI/TLS swiss army knife. It is both a command
> > > line tool and an HTTP API server for signing, verifying, and bundling
> > > TLS certificates."
> > 
> > The do-build and do-install bits can be simplified/replaced a bit:
> > 
> > do-build:
> >     cd ${WRKSRC}; ${MODGO_CMD} install github.com/cloudflare/cfssl/...
> > 
> > post-build:
> >     rm ${MODGO_WORKSPACE}/bin/example
> >     mv ${MODGO_WORKSPACE}/bin/mkbundle \
> >             ${MODGO_WORKSPACE}/bin/cfssl-mkbundle
> > 
> > Naming mkbundle cfssl-mkbundle removes the conflict with mono:
> > 
> >   mono-5.20.1.34p0:lang/mono:/usr/local/bin/mkbundle
> > 
> > Protip: having pkglocatedb installed lets the ports framework warn you of
> > such conflicts on 'make plist'!
> > 
> > I have re-attached with the above changes.
> 
> I think that should use
> 
> do-build:
>         cd ${WRKSRC}; ${MODGO_BUILD_CMD} github.com/cloudflare/cfssl/...
> 
> otherwise it doesn't use the standard flags (-v, -j #) .. and remove the
> MODGO_FLAGS=-mod=vendor line which AFAIK is currently unused but the above
> brings it in and breaks things.
> 
> Also either needs NO_TEST or fixing tests.

Ah, good catch. We can still do the tests with this (though, we get some
"executable not found in $PATH" failures :P):

do-test:
        cd ${WRKSRC}; ${MODGO_CMD} test github.com/cloudflare/cfssl/...

-- 
PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A  4AF0 1F81 112D 62A9 ADCE

Reply via email to