On Mon, Dec 16, 2019 at 06:15:45PM +0100, Paco Esteban wrote:
> Hello ports@,

> Here's an update for textproc/py-semver from 2.8.1 to 2.9.0.  You can
> find the changes for this version here:

> https://github.com/python-semver/python-semver/blob/master/CHANGELOG.rst#version-290

> I took the opportunity to add tests that now pass for py2 and py3.
> I'm not sure about a line `update-plist` introduced.  The one starting
> with `${MODPY_COMMENT}...`.  Is it save to leave it there ?

That one is fine. I re-ran and it lost the two above it. It's the
whole difference where python3 puts .pyc files in a separate directory
and python2 doesn't.

> And now the important bit:

> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/textproc/py-semver/pkg/PLIST,v
> retrieving revision 1.2
> diff -u -p -r1.2 PLIST
> --- pkg/PLIST 30 Jul 2018 14:07:05 -0000      1.2
> +++ pkg/PLIST 16 Dec 2019 17:09:29 -0000
> @@ -1,8 +1,13 @@
>  @comment $OpenBSD: PLIST,v 1.2 2018/07/30 14:07:05 jasper Exp $
> +bin/pysemver

This above line is problematic. It means the two flavors will
conflict. Could be solved by a potential rename. However, the only
port that uses this is python3 only, so it might be of easier to
convert the port to a python3-only port.

--Kurt

> +lib/python${MODPY_VERSION}/
> +lib/python${MODPY_VERSION}/site-packages/
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
>  
> lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}semver.${MODPY_PYC_MAGIC_TAG}pyc
>  
> lib/python${MODPY_VERSION}/site-packages/semver-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/
>  
> lib/python${MODPY_VERSION}/site-packages/semver-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
>  
> lib/python${MODPY_VERSION}/site-packages/semver-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
>  
> lib/python${MODPY_VERSION}/site-packages/semver-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
> +lib/python${MODPY_VERSION}/site-packages/semver-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/entry_points.txt
>  
> lib/python${MODPY_VERSION}/site-packages/semver-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
>  lib/python${MODPY_VERSION}/site-packages/semver.py
> 
> -- 
> Paco Esteban.
> 5818130B8A6DBC03
> 

Reply via email to