On Thu, Dec 19 2019, Charlene Wendling <[email protected]> wrote: > Hi, > > libfilezilla is broken in the current macppc bulk: > >> .libs/libfilezilla.so.1.0: undefined reference to `__atomic_store_8' > (and more undefined atomic primitives...) > > It builds fine on macppc [0] once proper LDFLAGS are provided. No > REVISION bump is needed, this newer version never built on macppc. > > Comments/feedback are welcome,
ok > Charlène. > > > [0] https://bin.charlenew.xyz/libfilezilla.log > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/net/libfilezilla/Makefile,v > retrieving revision 1.6 > diff -u -p -u -p -r1.6 Makefile > --- Makefile 9 Dec 2019 16:29:06 -0000 1.6 > +++ Makefile 18 Dec 2019 23:18:42 -0000 > @@ -38,4 +38,10 @@ CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE > AUTOCONF_VERSION = 2.69 > AUTOMAKE_VERSION = 1.15 > > +# undefined reference to `__atomic_store_8' > +.if ${MACHINE_ARCH:Mpowerpc} || ${MACHINE_ARCH:Mhppa} > +WANTLIB += atomic > +LDFLAGS += -latomic > +.endif > + > .include <bsd.port.mk> -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
