> > On Wed, 21 Aug 2019 21:09:33 +0200
> > Charlene Wendling wrote:
>
> > > > http://build-failures.rhaalovely.net/sparc64/2019-08-18/multimedia/mkvtoolnix%2Cno_x11.log
> > > (no full macppc bulk report available for now)
> > >
> > > What happens behind the scene (--trace didn't help):
> > >
> > > - $WRKSRC/rake.d/config.rb loads the 'build-config' file, that
> > > says that "COMPILER_VERSION = 8.3.0" (fine)
> > > - $WRKSRC/Rakefile does various compiler version checks to
> > > determine proper build flags to use
> > > - Compiler versions are checked in $WRKSRC/rake.d/helpers.rb using
> > > Ruby's check_version() function, that seems to not like version
> > > numbers with letters at the start, as we can see in the log.
> > > The compiler version itself comes from the c() function...
> > > - ...that is defined in $WRKSRC/rake.d/config.rb, where the line
> > > 24 is interesting:
> > >
> > > var = (ENV[idx_s].nil? ? $config[idx.to_sym] : ENV[idx_s]).to_s
> > >
> > > It appears that this 'gcc4' is coming from our default MAKE_ENV:
> > >
> > > $ make show=MAKE_ENV
> > > [...] COMPILER_VERSION="gcc4" [...]
> > > (on amd64, it returns COMPILER_VERSION="clang")
> > >
> > > It did not break on amd64, because with clang, upstream uses the
> > > same compilation flags for all versions, so there is no version
> > > comparison done.
> On Sun, 22 Sep 2019 11:30:49 +0200
> Charlene Wendling wrote:
>
> > There have been some out of list discussion about it.
> >
> > COMPILER_VERSION is unused in ports and we have PROPERTIES for the
> > same purpose. jca@ proposed to remove COMPILER_VERSION from MAKE_ENV
> > and test bulk the change. The issue being i can't do a (required)
> > full bulk myself.
Thanks to naddy@, it has been found out that removing COMPILER_VERSION
has no side effect in a amd64 bulk. So i'm proposing to remove it from
bsd.port.mk instead of modifying multimedia/mkvtoolnix.
Comments/feedback are welcome.
Index: bsd.port.mk
===================================================================
RCS file: /cvs/ports/infrastructure/mk/bsd.port.mk,v
retrieving revision 1.1514
diff -u -p -r1.1514 bsd.port.mk
--- bsd.port.mk 16 Dec 2019 09:18:27 -0000 1.1514
+++ bsd.port.mk 12 Jan 2020 17:38:22 -0000
@@ -843,8 +843,7 @@ COMPILER_LINKS += c++ ${CXX}
# copy selected info from bsd.own.mk
-MAKE_ENV += COMPILER_VERSION=${COMPILER_VERSION} \
- PICFLAG="${PICFLAG}" \
+MAKE_ENV += PICFLAG="${PICFLAG}" \
BINGRP=bin BINOWN=root BINMODE=${BINMODE} NONBINMODE=${NONBINMODE} \
DIRMODE=755 \
INSTALL_COPY=-c INSTALL_STRIP=${INSTALL_STRIP} \
