On Mon, Jan 13, 2020 at 03:53:19PM +0100, Solene Rapenne wrote: > On Sun, Jan 12, 2020 at 08:43:40PM +0100, Solene Rapenne wrote: > > this patch allows building firefox 72.0.1 on 6.6-stable without > > touching anything else. > > > > It's mostly a copy/paste of the -current ports but it uses nss, > > nspr and sqlite bundled with firefox. I disabled pledge and > > updated README according to this (saying it's off by default). > > > > built fine (after 482 minutes of building :P) and tested on amd64 > > > > this new diff import 1 patch from devel/nspr for bundled nspr and 1 > patch from security/nss to bundled nss (suggested by landry@!). > Those patches are bugfixes (I kept the comments), the others patches > didn't seem uesful in the context of a bundled library.
If it works for you at runtime and you get feedback from users, then im fine with it. > -SO_VERSION = 84.0 > +SO_VERSION = 87.0 Technically this is bumping a library major in -stable which has always been an issue i think, but since nothing builds against it afaict.. *shrug* > -BUILD_DEPENDS += devel/cbindgen>=0.9.0 > +BUILD_DEPENDS += devel/cbindgen>=0.9.1 You're lucky 6.6 ships with 0.9.1, but 73.0 will require 0.11 per https://bugzilla.mozilla.org/show_bug.cgi?id=1602317 - game over ? :) > +DEBUG_PACKAGES = ${BUILD_PACKAGES} > +DEBUG_CONFIGURE_ARGS += --enable-debug-symbols \ > + --disable-install-strip harmless, but since DEBUG_PACKAGES dont exist in 6.6, confusing ? as for the nss/nspr patches you backported, i didnt look but you get to decide which ones you choose since you're the one doing the work :) final note: i'm happy to see more people trying to work on those ports :) Someday, i'll be able to retire... final note 2: mail/mozilla-thunderbird might also need some love in -stable. Any takers ? Landry
