Bjorn Ketelaars <[email protected]> wrote:
> Just noticed that nnn compiles with '-O3'. As such it makes sense to set
> CFLAGS_OPTIMIZATION using MAKE_ENV in the port's Makefile.
>
> [...]
>
> +MAKE_ENV =           CFLAGS_OPTIMIZATION="${CFLAGS}"

The nnn Makefile already uses '+=' for CFLAGS, so wouldn't this add the
default CFLAGS twice?

 CFLAGS += -Wall -Wextra
 CFLAGS += $(CFLAGS_OPTIMIZATION)
 CFLAGS += $(CFLAGS_CURSES)

I think you can simply clear CFLAGS_OPTIMIZATION, that's what we do in
pkgsrc:

 MAKE_ENV+=      CFLAGS_OPTIMIZATION=

By the way, nnn 2.9 is out.

Sijmen

Reply via email to