Hi,

--
$ cd /usr/ports/converters/p5-JSON; make test 
[...]
Use of strings with code points over 0xFF as arguments to bitwise and
(&) operator is deprecated. This will be a fatal error in Perl 5.32
at /shm/pobj/p5-JSON-2.94/JSON-2.94/blib/lib/JSON/backportPP.pm line
424.

I think we're better off updating JSON and JSON::XS (versions are
supposed to be in sync) before we need to do an emergency fix. Note
that there are a bit less than 400 ports depending on these two.

I'll send the p5-JSON update that goes with it after that one.
--

Upstream's changelog is here [0], the main change is that it enables
allow_nonref [1] by default for compatibility with RFC 7159 and newer,
this has security implications [2].

Port-wise it's a quick update, i reordered things according to
Makefile.template, and fixed some spacing inconsistencies.

Testing:

- builds and passes tests fine on amd64 and powerpc
- i tested the direct consumers on amd64, and there are no failures
  due to that update [3] (there are network errors due to
  PORTS_PRIVSEP)


Comments/feedback are welcome,

Charlène.


[0] https://metacpan.org/changes/release/MLEHMANN/JSON-XS-4.02
[1] 
https://metacpan.org/pod/release/MLEHMANN/JSON-XS-4.02/XS.pm#$enabled-=-$json-%3Eget_allow_nonref
[2]
https://metacpan.org/pod/release/MLEHMANN/JSON-XS-4.02/XS.pm#SECURITY-CONSIDERATIONS
[3] https://bin.charlenew.xyz/p5-JSON-XS.tgz


Index: Makefile
===================================================================
RCS file: /cvs/ports/converters/p5-JSON-XS/Makefile,v
retrieving revision 1.27
diff -u -p -u -p -r1.27 Makefile
--- Makefile    12 Jul 2019 20:43:50 -0000      1.27
+++ Makefile    4 Feb 2020 18:32:24 -0000
@@ -2,18 +2,19 @@
 
 COMMENT =      JSON serialising/deserialising, done correctly and fast
 
-MODULES =      cpan
-DISTNAME =     JSON-XS-3.04
+DISTNAME =     JSON-XS-4.02
 EPOCH =                1
 CATEGORIES =   converters
 
 # Perl
 PERMIT_PACKAGE =       Yes
 
-WANTLIB += c perl
+WANTLIB +=     c perl
+
+MODULES =      cpan
 
-BUILD_DEPENDS= devel/p5-Canary-Stability
-RUN_DEPENDS=   converters/p5-Types-Serialiser \
+BUILD_DEPENDS =        devel/p5-Canary-Stability
+RUN_DEPENDS =  converters/p5-Types-Serialiser \
                devel/p5-common-sense
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/converters/p5-JSON-XS/distinfo,v
retrieving revision 1.13
diff -u -p -u -p -r1.13 distinfo
--- distinfo    27 Apr 2018 14:51:24 -0000      1.13
+++ distinfo    4 Feb 2020 18:32:24 -0000
@@ -1,2 +1,2 @@
-SHA256 (JSON-XS-3.04.tar.gz) = ZdiDa9jqbwt7/8cLIhIVatw+L/pYfiflSNV2iT8JfCw=
-SIZE (JSON-XS-3.04.tar.gz) = 83424
+SHA256 (JSON-XS-4.02.tar.gz) = pa0XITgHGhRynaigGSHKIz2k/ivtKQ/9+45WDditzxY=
+SIZE (JSON-XS-4.02.tar.gz) = 85904
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/converters/p5-JSON-XS/pkg/PLIST,v
retrieving revision 1.6
diff -u -p -u -p -r1.6 PLIST
--- pkg/PLIST   8 Mar 2016 14:20:18 -0000       1.6
+++ pkg/PLIST   4 Feb 2020 18:32:24 -0000
@@ -7,7 +7,7 @@ ${P5ARCH}/JSON/XS/Boolean.pm
 ${P5ARCH}/auto/
 ${P5ARCH}/auto/JSON/
 ${P5ARCH}/auto/JSON/XS/
-${P5ARCH}/auto/JSON/XS/XS.so
+@so ${P5ARCH}/auto/JSON/XS/XS.so
 @man man/man1/json_xs.1
 @man man/man3p/JSON::XS.3p
 @man man/man3p/JSON::XS::Boolean.3p

Reply via email to