On Sun, Feb 16, 2020 at 02:19:22PM +0100, Björn Ketelaars wrote: > On Sun 16/02/2020 11:23, Antoine Jacoutot wrote: > > On Sun, Feb 16, 2020 at 12:36:29AM +0100, Björn Ketelaars wrote: > > > Diff below brings bluefish to 2.2.11, which is a minor maintenance > > > release and minor feature release. Although this release supports > > > python3 the enclosed plugins only work on python2. As such, do not > > > switch to python3...for now. > > > > > > Changes to the port: > > > - Follow Makefile.template > > > - Sync WANTLIB and PLIST > > > - Add textproc/libxml as LDEP > > > - Bytecompile python plugins in post-install phase > > > > > > Run tested on amd64. Everything, including the plugins, seem to work. > > > > > > Comments/OK? > > > > > > > > > diff --git www/bluefish/Makefile www/bluefish/Makefile > > > index 2d6e9ab0570..72c0dec94ac 100644 > > > --- www/bluefish/Makefile > > > +++ www/bluefish/Makefile > > > @@ -2,27 +2,27 @@ > > > > > > COMMENT= HTML editor for experienced web designers > > > > > > -DISTNAME = bluefish-2.2.10 > > > +DISTNAME= bluefish-2.2.11 > > > + > > > CATEGORIES= www editors > > > -HOMEPAGE= http://bluefish.openoffice.nl/ > > > -REVISION = 6 > > > > > > -MASTER_SITES= http://www.bennewitz.com/bluefish/stable/source/ > > > +HOMEPAGE= http://bluefish.openoffice.nl/ > > > > > > # GPLv3 > > > PERMIT_PACKAGE= Yes > > > > > > -WANTLIB += ICE SM X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi > > > -WANTLIB += Xinerama Xrandr Xrender atk-1.0 atk-bridge-2.0 atspi > > > -WANTLIB += c cairo cairo-gobject dbus-1 enchant epoxy expat ffi > > > -WANTLIB += fontconfig freetype gdk-3 gdk_pixbuf-2.0 gio-2.0 glib-2.0 > > > -WANTLIB += gmodule-2.0 gobject-2.0 graphite2 gthread-2.0 gtk-3 > > > +WANTLIB += ${COMPILER_LIBCXX} ${MODPY_WANTLIB} X11 Xcomposite Xcursor > > > +WANTLIB += Xdamage Xext Xfixes Xi Xinerama Xrandr Xrender atk-1.0 > > > +WANTLIB += atk-bridge-2.0 c cairo cairo-gobject enchant epoxy expat ffi > > > +WANTLIB += fontconfig freetype fribidi gdk-3 gdk_pixbuf-2.0 gio-2.0 > > > +WANTLIB += glib-2.0 gmodule-2.0 gobject-2.0 graphite2 gthread-2.0 gtk-3 > > > WANTLIB += gucharmap_2_90 harfbuzz iconv intl lzma m pango-1.0 > > > -WANTLIB += pangocairo-1.0 pangoft2-1.0 pcre pixman-1 png pthread > > > -WANTLIB += ${MODPY_WANTLIB} ${COMPILER_LIBCXX} util xcb xcb-render > > > -WANTLIB += xcb-shm xml2 z fribidi > > > +WANTLIB += pangocairo-1.0 pangoft2-1.0 pcre pixman-1 png util xcb > > > +WANTLIB += xcb-render xcb-shm xml2 z > > > > > > -COMPILER = base-clang ports-gcc base-gcc > > > +MASTER_SITES= > > > https://www.bennewitz.com/bluefish/stable/source/ > > > + > > > +COMPILER= base-clang ports-gcc base-gcc > > > > > > MODULES= lang/python \ > > > textproc/intltool > > > @@ -30,14 +30,13 @@ MODULES= lang/python \ > > > RUN_DEPENDS= devel/desktop-file-utils \ > > > misc/shared-mime-info \ > > > x11/gtk+3,-guic > > > - > > > LIB_DEPENDS= textproc/enchant \ > > > + textproc/libxml \ > > > x11/gnome/gucharmap > > > > Why this change in LIB_DEPENDS? > > From ${WRKSRC}/INSTALL: > > 1) Compilation needs the following software packages - usually the headers and > libraries (search for packages with a -dev or -devel suffix and/or prefix > lib, e.g. libgtk2.0-dev) > > - Gtk 2 (2.20 or newer) or 3 (3.2.2) or newer > - libxml2 > - libenchant (optional for spell checking) > - libgucharmap (optional for character map plugin. Version 2.x is > recommended) > - python-dev (optional)
Yes but that is already satisfied by the dependency chain. Look at WANTLIB. If you want to explicitely set all direct depends then you are missing python and gtk at least. And I don't recommend doing this, it makes ports work more painful. -- Antoine
