On Sat, Feb 15, 2020 at 09:29:38PM -0500, Kurt Mosiejczuk wrote:
> GCC does not like -Wpedantic
Could you put a comment in the patch file that gcc 4.2.1 does not
understand -Wpedantic ?
> Removing it fixes the build on sparc64 and doesn't hurt the build
> on amd64.
>
> ok?
OK bluhm@
> Index: patches/patch-CMakeLists_txt
> ===================================================================
> RCS file: /cvs/ports/misc/open62541/patches/patch-CMakeLists_txt,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 patch-CMakeLists_txt
> --- patches/patch-CMakeLists_txt 11 Feb 2020 10:35:25 -0000 1.1.1.1
> +++ patches/patch-CMakeLists_txt 16 Feb 2020 02:27:06 -0000
> @@ -3,6 +3,15 @@ $OpenBSD: patch-CMakeLists_txt,v 1.1.1.1
> Index: CMakeLists.txt
> --- CMakeLists.txt.orig
> +++ CMakeLists.txt
> +@@ -389,7 +389,7 @@ include(CompilerFlags)
> + if(NOT UA_COMPILE_AS_CXX AND (CMAKE_COMPILER_IS_GNUCC OR
> "x${CMAKE_C_COMPILER_ID}" STREQUAL "xClang"))
> + # Compiler
> + add_definitions(-std=c99 -pipe
> +- -Wall -Wextra -Wpedantic
> ++ -Wall -Wextra
> + -Wno-static-in-inline # clang doesn't like the use of
> static inline methods inside static inline methods
> + -Wno-overlength-strings # may happen in the nodeset
> compiler when complex values are directly encoded
> + -Wno-unused-parameter # some methods may require unused
> arguments to cast to a method pointer
> @@ -1236,7 +1236,7 @@ if (UA_PACK_DEBIAN)
> "examples/nodeset"
> "examples/pubsub")
