On Tue, Mar 03, 2020 at 12:46:26PM +0100, Bjorn Ketelaars wrote:
> On Tue 03/03/2020 11:15, Martin Reindl wrote:
> > Hello,
> >
> > I already sent h5py to the list in january, but resending now with
> > py-pkgconfig,which is a BDEP for h5py.
> >
> > h5py is a requirement for xrayutilities which, I understand, David is or was
> > working on. bcallah@ also sent out a version in 2015 which never made it
> > into
> > the tree.
> >
> > Both ports are python3-only. py-pkgconfig is the python interface to
> > pkgconfig
> > and might be useful for other ports as well. It comes without tests.
> >
> > h5py test results look good:
> > 522 passed, 24 skipped, 3 xfailed, 2 warnings
> >
> > Comments? OK to import?
>
> License marker in py-pkgconfig/Makefile is wrong. py-pkgconfig is
> licensed under MIT. Rest of port reads ok and build tested on amd64.
>
> After fixing the license marker OK bket@ for importing py-pkgconfig.
>
>
> Concerning h5py:
>
> Builds and runs ok on amd64. All tests in 'make tests' run successfully.
> One nit:
>
> diff --git math/h5py/Makefile math/h5py/Makefile
> index 3b58ee7dcb1..027bcc8ebf1 100644
> --- math/h5py/Makefile
> +++ math/h5py/Makefile
> @@ -25,7 +25,7 @@ WANTLIB = pthread ${MODPY_WANTLIB} hdf5 hdf5_hl
>
> BUILD_DEPENDS = lang/cython${MODPY_FLAVOR} \
> math/py-numpy${MODPY_FLAVOR} \
> - devel/py-pkgconfig
> + devel/py-pkgconfig${MODPY_FLAVOR}
>
> LIB_DEPENDS = math/hdf5
>
> With the above OK bket@ to import h5py.
Thanks for your input and testing, somehow I was under the wrong impression
that this is not needed if a dependency is python3-only (It works without
but might break in the future).
-m
