On Thu, Mar 05 2020, Thomas Frohwein <[email protected]> wrote: > Charlene, Theo, > > Thanks for the input. I have an expanded diff taking all of this into > account. > > The additions are: > > - Instead of stub resolve function in uv.c, use the commit from Motion > Twin. This allows leaderboards and daily challenges to work in Dead > Cells. > - Add conditionals for typedef's for char{16,32}_t in hl.h. Otherwise, > including this in C++ projects with clang fails. Noticed with [1]. > brynet@ helped figure out the logic here. > > Still builds and runs on amd64. > > I would appreciate testing on a gcc arch, Charlene maybe?
Please, let Charlene commit her diff to fix hashlink on powerpc/sparc64. I see no reason to delay adding those fixes. 1. Your additional changes are unrelated and it would be nicer to commit them separately. REVISION bumps are cheap. 2. This lets the person who did the job commit their improvements, which results in better acknowledgement of her efforts. My two cents, -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
