On Wed, Mar 11, 2020 at 05:47:59PM +0100, Jeremie Courreges-Anglas wrote: > On Wed, Mar 11 2020, Solene Rapenne <[email protected]> wrote: > > Hi, this is a port to bring gsplus, an Apple IIgs emulator > > > > I had to patch a timeval struct use leading to a compilation error, I'm > > not sure I correctly fixed it though. > > Looking at the rest of the file, this function is duplicated with > various versions used epending on the OS, and all the other versions > have this line commented out. The line doesn't do anything anyway since > the times array is initialized to 0s using memset. > > It seems bogus to set the access time to 0 (Jan 1 01:00:00 1970) but > I guess that's a detail that corrects itself once you open the file > again... To avoid this you can either set times[0] to current access > time of the file or the current time, or use the convenient utimensat(2) > interface and its UTIME_NOW/OMIT special values.
I prefer not to touch this, if it's doing nothing then it's fine, if I add code I may introduce bugs :) If someone wants to improve this, that would be nice though > > I'm still trying to figure out to use this emulator, if someone have a > > clue please share :) It asks for a ROM (seems like the "bios" or system > > equivalent?) and it's possible to feed it with floppies images. > > > > The port was super easy to do and pass dpb build in a fresh chroot, I > > hope this will be easy to review. > > LGTM ports-wise, I think you should set NO_TEST=Yes and maybe install > stuff under the doc/ directory, eg doc/README.txt and > doc/gsplusmanual.pdf. If it proves useful, that is. :) > here a new version from your and bcallah@ inputs - added NO_TEST=yes - added some doc which are really helpful (ive been able to start something) - added some files which gsplus was looking for (not sure about the use but in console it complains about them missing) - add myself as maintainer - fixed license, it's GPLv2 PLUS
gsplus.tar.gz
Description: application/tar-gz
