On Fri, Mar 13 2020, Paul Irofti <p...@irofti.net> wrote:
> Hi,
>
> Thank you for your effort! I have a few comments and questions.
I got curious about this proposal, mostly because of the COMPILER line
change.
> I see they switched to Gitlab (hence the url changes) and that the
> author set it up for continous integration and thus made it compile with
> clang.
>
> Why did you bump the major. I tried browsing the history on Gitlab to
> see what changed in the API, but couldn't see much. I am sure I missed
> something.
As shown by /usr/src/lib/check_sym ("No dynamic export changes"), and
a diff of the installed include file, the shared lib version bump
appears unnecessary.
> Is the gnuplot bump necessary? Why?
Maybe Yozo found it useful for testing, but it doesn't seem useful for
the ports tree.
The updated diff below has been stripped from the items that
I mentioned. It also updates WANTLIB, no need for COMPILER_LIBCXX since
this is a C-only port. Builds fine on sparc64 along with
gnuplot,no_x11. Paul, feel free to use the diff below.
Index: Makefile
===================================================================
RCS file: /cvs/ports/math/libcerf/Makefile,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile
--- Makefile 12 Jul 2019 20:47:42 -0000 1.5
+++ Makefile 14 Mar 2020 00:23:15 -0000
@@ -2,26 +2,24 @@
COMMENT = implementation of complex error functions
-V = 1.11
-DISTNAME = libcerf-${V}
+V = 1.13
+DISTNAME = libcerf-v${V}
+PKGNAME = libcerf-${V}
EXTRACT_SUFX = .tgz
CATEGORIES = math
-MASTER_SITES = http://apps.jcns.fz-juelich.de/src/libcerf/
-REVISION = 0
+MASTER_SITES = https://jugit.fz-juelich.de/mlz/libcerf/-/archive/v${V}/
-SHARED_LIBS += cerf 2.0 # 1.10
+SHARED_LIBS += cerf 2.0 # 1.13
-HOMEPAGE = http://apps.jcns.fz-juelich.de/doku/sc/libcerf
+HOMEPAGE = https://jugit.fz-juelich.de/mlz/libcerf/
MAINTAINER = Paul Irofti <piro...@openbsd.org>
# MIT
PERMIT_PACKAGE = Yes
-WANTLIB += c m ${COMPILER_LIBCXX}
+WANTLIB += m
MODULES = devel/cmake
-
-COMPILER = ports-gcc # imaginary constants are a GNU extension
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/math/libcerf/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo 29 Dec 2018 07:48:36 -0000 1.3
+++ distinfo 14 Mar 2020 00:23:15 -0000
@@ -1,2 +1,2 @@
-SHA256 (libcerf-1.11.tgz) = cBAcrEoNeGMyLU0Gz5XFB6nP1k/JmtGzGoQlIEz9lnI=
-SIZE (libcerf-1.11.tgz) = 60066
+SHA256 (libcerf-v1.13.tgz) = 5Gmfga+Diu9bPncgn+yOmCCk9JLVmPtaBwgAhUl2owU=
+SIZE (libcerf-v1.13.tgz) = 60732
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
