On Tue, Mar 24, 2020 at 11:22:39PM -0400, Chris Bennett wrote:
> On Wed, Mar 25, 2020 at 02:46:32AM +0000, wen heping wrote:
> > Hi,
> >
> > It build well and pass all tests.
> > But I have two suggestions:
> > i) sysutils/p5-Capture-Tiny is not needed in TEST_DEPENDS.
> > ii) I would use "CONFIGURE_STYLE = modinst" instead of BUILD_DEPENDS
> > = devel/p5-Module-Install.
> >
>
> I don't know why, but I gave up on that because of the following error:
It is only a warning and doesn't change the package at all, but it is
sort-of a bug in the module, since it doesn't that it doesn't need those
files if Module::Install isn't using the bundled version.
You can work around it with something like:
pre-configure:
sed -i.orig '/^inc/d' ${WRKSRC}/MANIFEST
In any case, although xt/99-compile.t does use Capture::Tiny, we don't
run the xt tests and so I agree I agree that it is not needed.
Other than those comments, I think this looks good.
>
> ===> p5-HTML-Selector-XPath-0.25 depends on: p5-Module-Install-* ->
> p5-Module-Install-1.18
> ===> Extracting for p5-HTML-Selector-XPath-0.25
> FFLR p5-HTML-Selector-XPath $ MB
> ===> Patching for p5-HTML-Selector-XPath-0.25
> ===> Compiler link: clang -> /usr/bin/clang
> ===> Compiler link: clang++ -> /usr/bin/clang++
> ===> Compiler link: cc -> /usr/bin/cc
> ===> Compiler link: c++ -> /usr/bin/c++
> ===> Generating configure for p5-HTML-Selector-XPath-0.25
> ===> Configuring for p5-HTML-Selector-XPath-0.25
> Checking if your kit is complete...
> Warning: the following files are missing in your kit:
> inc/Module/Install.pm
> inc/Module/Install/Base.pm
> inc/Module/Install/Can.pm
> inc/Module/Install/Fetch.pm
> inc/Module/Install/Makefile.pm
> inc/Module/Install/Metadata.pm
> inc/Module/Install/Win32.pm
> inc/Module/Install/WriteAll.pm
> Please inform the author.
> Generating a Unix-style Makefile
> -------------------------------------------------
> Using the BUILD_DEPENDS solves the problem.
>
> Is this a bug in the port or with ports infrastructure?
> Or a bug with me?
>
> Yes, you are right. Looking closer I see that the test needing
> Capture-Tiny isn't run. I will look closer for that in the future.
>
> Thank you.
> --
> Chris Bennett
>
>
> # $OpenBSD: Makefile.template,v 1.85 2019/09/09 19:19:05 kmos Exp $
>
> COMMENT = CSS Selector to XPath compiler
>
> DISTNAME = HTML-Selector-XPath-0.25
>
> CATEGORIES = www
>
> # Perl
> PERMIT_PACKAGE = Yes
>
> MODULES = cpan
>
> BUILD_DEPENDS = devel/p5-Module-Install
>
> TEST_DEPENDS = devel/p5-Test-Base
>
> MAKE_ENV += TEST_POD=Yes
>
> PKG_ARCH = *
>
> .include <bsd.port.mk>
>
--
andrew - http://afresh1.com
What are the unsurpassable real world weaknesses in OpenBSD,
that you know of?
-- Kevin Chadwick <[email protected]>
Lots of fake people attacking the project on the mailing lists makes
them a poor resource for users.
-- Theo de Raadt <[email protected]>
