Hi,
Can we get this in for 6.7 ?
On Sun, Feb 09, 2020 at 10:31:14AM +0100, Stephane Guedon wrote:
> Le samedi 1 février 2020, 15:43:59 CET Stuart Henderson a écrit :
> > On 2020/02/01 10:06, Stephane Guedon wrote:
> > > Le mercredi 29 janvier 2020, 22:20:25 CET Stuart Henderson a écrit :
> > > > - either use the directory "vips", or name the package "libvips",
> > > > just pick one or the other. "PKGNAME= lib${DISTNAME}" will do if
> > > > you
> > > > want libvips.
> > > >
> > > > (if it's better known as a library then prefer "libvips", if it's
> > > > better known for the tools then prefer just "vips").
> > > >
> > > > - seems more like a port that should be in "graphics" rather than
> > > > multimedia?
> > > >
> > > > - the comment "# Dependencies" doesn't add anything that
> > > > LIB_DEPENDS
> > > > doesn't already say, please zap
> > > >
> > > > - plist was generated on stable or old current, it should be
> > > > udpated
> > > > on -current (some of the files will get "@static-lib" markers)
> > > >
> > > > - there are a number of unlisted dependencies that are picked up
> > > > by configure if present at build time. these must either be
> > > > disabled,
> > > > or explicit dependencies added. at least one of these adds extra
> > > > PLIST files (gir) and I get about 50 lines of output from "make
> > > > port-lib-depends-check" for things which are either "NOT
> > > > REACHABLE"
> > > > (no LIB_DEPENDS to pull in the library) or just "Missing:" (where
> > > > there is a dependency path but no WANTLIB entry for them).
> > > >
> > > > libvips-8.9.0(graphics/libvips):
> > > > Missing lib: Half-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > > REACHABLE) Missing: ICE.11 (/usr/local/lib/libvips.so.0.0) (system
> > > > lib) Missing lib: Iex-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > > REACHABLE) Missing lib: IexMath-2_4.0
> > > > (/usr/local/lib/libvips.so.0.0)
> > > > (NOT REACHABLE) Missing lib: IlmImf-2_4.0
> > > > (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing lib:
> > > > IlmThread-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE)
> > > > Missing lib: Imath-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > > REACHABLE) Missing lib: MagickCore-6.Q16.7
> > > > (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing: SM.9
> > > > (/usr/local/lib/libvips.so.0.0) (system lib)
> > > > Missing: X11.17 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > > Missing: Xext.13 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > > Missing: Xrender.6 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > > Missing: Xt.11 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > > Missing: bz2.10 from bzip2-1.0.8 (/usr/local/lib/libvips.so.0.0)
> > > > Missing lib: cairo-gobject.2 (/usr/local/lib/libvips.so.0.0) (NOT
> > > > REACHABLE) Missing lib: cairo.13 (/usr/local/lib/libvips.so.0.0)
> > > > (NOT
> > > > REACHABLE) Missing lib: djvulibre.26
> > > > (/usr/local/lib/libvips.so.0.0)
> > > > (NOT REACHABLE) <..snip..>
> > > >
> > > > and an excerpt from the configure check showing the sort of things
> > > > you're looking for in there, all various things where there's a
> > > > check
> > > > which doesn't find the relevant dependency, decide whether you
> > > > want
> > > > to list the dependency or add the relevant CONFIGURE_ARGS line to
> > > > disable it.
> > > >
> > > > checking for IceConnectionNumber in -lICE... (cached) yes
> > > > checking for NIFTI... libraries (none), headers (none)
> > > > checking for HEIF... no
> > > > configure: WARNING: libheif not found; disabling HEIF support
> > > > checking for PDFIUM... libraries (none), headers (none)
> > > > checking for POPPLER... yes
> > > > checking for RSVG... yes
> > > > checking for ZLIB... yes
> > > > checking for OPENSLIDE... no
> > > > configure: OpenSlide >= 3.4.0 not found; checking for >= 3.3.0
> > > > checking for OPENSLIDE... no
> > > > configure: WARNING: OpenSlide >= 3.3.0 not found; disabling
> > > > virtual
> > > > slide support checking for MATIO... no
> > > > configure: WARNING: matio not found; disabling matio support
> > > > checking for CFITSIO... no
> > > > configure: WARNING: cfitsio not found; disabling cfitsio support
> > > > checking for LIBWEBP... yes
> > > > checking for PANGOFT2... yes
> > > > checking for TIFF... yes
> > > > checking whether COMPRESSION_WEBP is declared... no
> > > > checking for giflib... libraries -L/usr/local/lib -lgif, headers
> > > > -I/usr/local/include checking for PNG... yes
> > > > checking for png_set_chunk_malloc_max... yes
> > > > checking for IMAGEQUANT... no
> > > > configure: WARNING: libimagequant not found; disabling 8bpp PNG
> > > > support checking for JPEG... yes
> > > > checking for jpeg_c_bool_param_supported... no
> > > > checking for EXIF... yes
> > > > checking exif-data.h usability... yes
> > > > checking exif-data.h presence... yes
> > > > checking for exif-data.h... yes
> > > >
> > > > Tip: if you're doing various rebuilds while working on disabling
> > > > things etc, building with USE_CCACHE=Yes (set in mk.conf or on the
> > > > make command-line) will save you a bunch of time.
> > >
> > > Hello. Here is a new try after that I tried to apply your advices.
> > > Let me know what you think.
> > >
> > > I disabled some optional dependencies and placed the port in
> > > graphics
> > > notably.
> >
> > I have attached a version that disables all things from autoconf that
> > use an external library that didn't have a dependency listed.
> > (I'm not making any comment on _which_ ones should be
> > enabled/disabled, I haven't considered that at all, just keeping
> > things in sync).
> >
> > Also cleaned a few things and removed SEPARATE_BUILD because it breaks
> > tests. Doing that also means that the pregenerated gtk-docs are
> > installed.
> >
> > BTW your "tar.gz" attachments are uncompressed.
>
> Updated after sthen's advices.
>
